Issue 12391047: apps: Stop depending on chrome_switches.h

Issue 12391047: apps: Stop depending on chrome_switches.h (Closed)

Created:
7 years, 9 months ago by tfarina

Modified:
7 years, 9 months ago

Reviewers:
benwells

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

apps: Stop depending on chrome_switches.h Instead move kShowAppListShortcut to a new apps_switches.h BUG=159366 R=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185833

Patch Set 2 : switches and update DEPS file #

Total comments: 2

Patch Set 3 : fix win #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -27 lines)			Patch
M	apps/DEPS	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	apps/app_launcher.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	apps/apps.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	apps/switches.h	View	1	1 chunk	+6 lines, -8 lines	0 comments	Download
A +	apps/switches.cc	View	1	1 chunk	+5 lines, -9 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/webstore_private/webstore_private_api.cc	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/app_list/app_list_controller_win.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

benwells

Can we make the new file name just switches.x instead of apps_switches.x?

7 years, 9 months ago (2013-03-04 01:23:43 UTC) #1

tfarina

On 2013/03/04 01:23:43, benwells wrote: > Can we make the new file name just switches.x ...

7 years, 9 months ago (2013-03-04 01:29:07 UTC) #2

benwells

lgtm with the one comment. https://codereview.chromium.org/12391047/diff/11/chrome/browser/ui/views/app_list/app_list_controller_win.cc File chrome/browser/ui/views/app_list/app_list_controller_win.cc (right): https://codereview.chromium.org/12391047/diff/11/chrome/browser/ui/views/app_list/app_list_controller_win.cc#newcode714 chrome/browser/ui/views/app_list/app_list_controller_win.cc:714: switches::kShowAppListShortcut); this should be ...

7 years, 9 months ago (2013-03-04 02:05:34 UTC) #3

tfarina

https://codereview.chromium.org/12391047/diff/11/chrome/browser/ui/views/app_list/app_list_controller_win.cc File chrome/browser/ui/views/app_list/app_list_controller_win.cc (right): https://codereview.chromium.org/12391047/diff/11/chrome/browser/ui/views/app_list/app_list_controller_win.cc#newcode714 chrome/browser/ui/views/app_list/app_list_controller_win.cc:714: switches::kShowAppListShortcut); On 2013/03/04 02:05:34, benwells wrote: > this should ...

7 years, 9 months ago (2013-03-04 02:18:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12391047/5001

7 years, 9 months ago (2013-03-04 02:21:19 UTC) #5

Message was sent while issue was closed.

Change committed as 185833

Expand Messages | Collapse Messages