Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 12391041: Fix ManyPopupNotifications test with --enable-rich-notifications. (Closed)

Created:
7 years, 9 months ago by dewittj
Modified:
7 years, 9 months ago
Reviewers:
stevenjb, Jun Mukai
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix ManyPopupNotifications test with --enable-rich-notifications. The switch to MessagePopupCollection broke this test but wasn't caught on the try bots since --enable-rich-notifications isn't run there. R=stevenjb@chromium.org TBR=mukai@chromium.org BUG=NONE TEST=ash_unittests --enable-rich-notifications Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186241

Patch Set 1 #

Patch Set 2 : Merge with master. #

Patch Set 3 : Notice that my file moved. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 2 2 chunks +12 lines, -2 lines 0 comments Download
M ui/message_center/views/message_popup_collection.h View 1 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dewittj
Sorry for review spam, this is a duplicate of 12381048 with a corrected baseurl.
7 years, 9 months ago (2013-03-01 21:59:25 UTC) #1
Jun Mukai
lgtm
7 years, 9 months ago (2013-03-01 22:03:24 UTC) #2
stevenjb
lgtm
7 years, 9 months ago (2013-03-04 19:38:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/12391041/1
7 years, 9 months ago (2013-03-04 20:51:03 UTC) #4
commit-bot: I haz the power
Failed to apply patch for ash/system/web_notification/web_notification_tray_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 9 months ago (2013-03-05 00:15:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/12391041/4003
7 years, 9 months ago (2013-03-05 17:41:27 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 20:26:33 UTC) #7
Message was sent while issue was closed.
Change committed as 186241

Powered by Google App Engine
This is Rietveld 408576698