Give an app the file entries it had back on restart.

Give an app the file entries it had back on restart.


BUG=165832
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187846

[koz (OOO until 15th September), 2013-02-28 05:37:42]

This is the third and final piece of the file preservation change from a million
years ago that has been lying dormant on my linux box.

[benwells, 2013-02-28 06:40:31]

On 2013/02/28 05:37:42, koz wrote:
> This is the third and final piece of the file preservation change from a
million
> years ago that has been lying dormant on my linux box.

Lotsa red on those bots...

[koz (OOO until 15th September), 2013-02-28 08:01:36]

On 2013/02/28 06:40:31, benwells wrote:
> On 2013/02/28 05:37:42, koz wrote:
> > This is the third and final piece of the file preservation change from a
> million
> > years ago that has been lying dormant on my linux box.
> 
> Lotsa red on those bots...

Hm, works for me. Looks like they are choking because they think the new
index.html file is a rename of an old one... I can tell this is going to be fun
to land.

[koz (OOO until 15th September), 2013-03-13 03:08:50]

Friendly ping.

[benwells, 2013-03-13 03:58:29]

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
chrome/browser/extensions/extension_service.cc:746:
extension_prefs_->GetSavedFileEntries(
Should it just do this if events & RESTART?

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
chrome/browser/extensions/extension_service.cc:2912: NOTREACHED();
I'm not quite sure about this NOTREACHED. It feels like it might bite at the
wrong time, but it's probably fine.

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
File chrome/browser/extensions/platform_app_launcher.cc (right):

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:316: class
PlatformAppWebIntentLauncher
This guy has been deleted.

https://codereview.chromium.org/12391006/diff/12001/chrome/renderer/resources...
File chrome/renderer/resources/extensions/app_runtime_custom_bindings.js
(right):

https://codereview.chromium.org/12391006/diff/12001/chrome/renderer/resources...
chrome/renderer/resources/extensions/app_runtime_custom_bindings.js:36:
(function(fe, fs) {
Why is this done in an anonymous function?

[koz (OOO until 15th September), 2013-03-13 05:01:13]

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
File chrome/browser/extensions/extension_service.cc (right):

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
chrome/browser/extensions/extension_service.cc:746:
extension_prefs_->GetSavedFileEntries(
On 2013/03/13 03:58:29, benwells wrote:
> Should it just do this if events & RESTART?

Yes, good spot.
Done.

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
chrome/browser/extensions/extension_service.cc:2912: NOTREACHED();
On 2013/03/13 03:58:29, benwells wrote:
> I'm not quite sure about this NOTREACHED. It feels like it might bite at the
> wrong time, but it's probably fine.

Yeah, my rationale is that it'd be a programmer error if we hit this.

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
File chrome/browser/extensions/platform_app_launcher.cc (right):

https://codereview.chromium.org/12391006/diff/12001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:316: class
PlatformAppWebIntentLauncher
On 2013/03/13 03:58:29, benwells wrote:
> This guy has been deleted.

Oops, and commented out in my change, too.
Removed.

https://codereview.chromium.org/12391006/diff/12001/chrome/renderer/resources...
File chrome/renderer/resources/extensions/app_runtime_custom_bindings.js
(right):

https://codereview.chromium.org/12391006/diff/12001/chrome/renderer/resources...
chrome/renderer/resources/extensions/app_runtime_custom_bindings.js:36:
(function(fe, fs) {
On 2013/03/13 03:58:29, benwells wrote:
> Why is this done in an anonymous function?

Because the var fe, fs above are actually scoped to the outer function(), not
the for loop's body (in JS only function(){} blocks are new scopes), which means
that after every iteration of the loop the fe and fs variables are modified for
all closures they are in.

See
http://stackoverflow.com/questions/1676362/javascript-variable-binding-and-loop

[benwells, 2013-03-13 05:09:11]

lgtm

[commit-bot: I haz the power, 2013-03-13 05:24:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/12391006/29001

[commit-bot: I haz the power, 2013-03-13 05:49:35]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-13 06:36:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/12391006/30014

[commit-bot: I haz the power, 2013-03-13 13:15:00]

Change committed as 187846