chromeos: Add DisplayPowerServiceProvider.

chromeos: Add DisplayPowerServiceProvider.

This makes Chrome export a SetDisplayPower D-Bus method call
for the power manager.

It also reworks OutputConfigurator to cache the
most-recently-requested power state and use it for future
display mode requests.

Finally, it works around a related bug where multiple mouse
events may be generated when the displays are reconfigured,
which would result in a report of user activity that could
abort suspending.

BUG=chromium-os:39289, 180348, chrome-os-partner:12662
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186625

[Daniel Erat, 2013-02-28 01:48:53]

https://codereview.chromium.org/12391004/diff/1/chromeos/display/output_confi...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/12391004/diff/1/chromeos/display/output_confi...
chromeos/display/output_configurator.cc:688: config.x = 0;
I'm not sure how to test that this still works as intended.  The existing code
already seems to not do what I'd expect in some cases (e.g. if I connect an
external display to lumpy and reduce the brightness to 0, I can still see a
faint image on the screen even though powerd told Chrome to turn the internal
display off).

[marcheu, 2013-02-28 04:58:59]

Didn't look at the output_configurator in depth yet, but that'll have to wait
for tomorrow.

https://codereview.chromium.org/12391004/diff/1/chrome/browser/chromeos/dbus/...
File chrome/browser/chromeos/dbus/display_power_service_provider.cc (right):

https://codereview.chromium.org/12391004/diff/1/chrome/browser/chromeos/dbus/...
chrome/browser/chromeos/dbus/display_power_service_provider.cc:62: // that it
can ignore such events.
So I think this applies to all root window resizes, not power off specifically.

[Daniel Erat, 2013-02-28 18:13:13]

https://codereview.chromium.org/12391004/diff/1/chrome/browser/chromeos/dbus/...
File chrome/browser/chromeos/dbus/display_power_service_provider.cc (right):

https://codereview.chromium.org/12391004/diff/1/chrome/browser/chromeos/dbus/...
chrome/browser/chromeos/dbus/display_power_service_provider.cc:62: // that it
can ignore such events.
On 2013/02/28 04:58:59, marcheu wrote:
> So I think this applies to all root window resizes, not power off
specifically.

Probably; I was just copying over the existing logic from OutputObserver.

[marcheu, 2013-03-01 01:12:40]

lgtm

[Daniel Erat, 2013-03-06 01:26:55]

Another look?

[marcheu, 2013-03-07 00:56:30]

lgtm

[commit-bot: I haz the power, 2013-03-07 01:06:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/12391004/25001

[commit-bot: I haz the power, 2013-03-07 01:06:34]

Presubmit check for 12391004-25001 failed and returned exit status 1.

INFO:root:Found 17 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/chrome_browser_chromeos.gypi

Presubmit checks took 1.7s to calculate.

[Daniel Erat, 2013-03-07 01:08:05]

TBR sky for .gypi

[commit-bot: I haz the power, 2013-03-07 01:08:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/12391004/25001

[commit-bot: I haz the power, 2013-03-07 02:43:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/12391004/44001

[commit-bot: I haz the power, 2013-03-07 05:24:08]

Change committed as 186625