Issue 12390082: Fix some comments in DeleteChromeRegistrationKeys.

Issue 12390082: Fix some comments in DeleteChromeRegistrationKeys. (Closed)

Created:
7 years, 9 months ago by gab

Modified:
7 years, 9 months ago

Reviewers:
grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix some comments in DeleteChromeRegistrationKeys. Those comments were invalidated as of http://crrev.com/154145 R=grt@chromium.org NOTRY=True BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186184

Patch Set 2 : +periods #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/installer/setup/uninstall.cc	View	1	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

gab

Sir, just stumbled upon those comments while reading some uninstall code. This is definitely no ...

7 years, 9 months ago (2013-03-05 03:26:47 UTC) #1

grt (UTC plus 2)

lgtm w/ nits. just to confirm: the comment is incorrect because HKLM is written to ...

7 years, 9 months ago (2013-03-05 15:06:58 UTC) #2

gab

Right, user-level writes to HKLM pre-Win8. Thanks, Gab https://codereview.chromium.org/12390082/diff/1/chrome/installer/setup/uninstall.cc File chrome/installer/setup/uninstall.cc (right): https://codereview.chromium.org/12390082/diff/1/chrome/installer/setup/uninstall.cc#newcode766 chrome/installer/setup/uninstall.cc:766: // ...

7 years, 9 months ago (2013-03-05 16:14:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12390082/4001

7 years, 9 months ago (2013-03-05 16:15:04 UTC) #4

Message was sent while issue was closed.

Change committed as 186184

Expand Messages | Collapse Messages