Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: remoting/host/desktop_process.cc

Issue 12390027: Crash the network or desktop process when an unknown IPC message is received. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/desktop_process.cc
diff --git a/remoting/host/desktop_process.cc b/remoting/host/desktop_process.cc
index a994e2207dce8d50d82b79a41a75275acdc03e09..2ff6f2de32fe0658c5a86088e5289de50e915b77 100644
--- a/remoting/host/desktop_process.cc
+++ b/remoting/host/desktop_process.cc
@@ -61,6 +61,9 @@ bool DesktopProcess::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ChromotingDaemonDesktopMsg_Crash, OnCrash)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
+
+ CHECK(handled) << "An unexpected IPC message received: type="
Wez 2013/03/04 23:17:09 nit: "Received unexpected IPC type:"?
alexeypa (please no reviews) 2013/03/05 00:01:44 Done.
+ << message.type();
return handled;
}

Powered by Google App Engine
This is Rietveld 408576698