Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 12389084: Fix Aura backing store to work with non-integer scale factors. (Closed)

Created:
7 years, 9 months ago by kevers
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix aura backing store to work with non-integer scale factors. BUG=179982 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187289

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits. #

Patch Set 3 : Merge with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M content/browser/renderer_host/backing_store_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/backing_store_aura.cc View 1 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kevers
Hi Ben, Can you please have a look at this CL.
7 years, 9 months ago (2013-03-04 21:05:59 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 9 months ago (2013-03-07 21:25:00 UTC) #2
pkotwicz
https://codereview.chromium.org/12389084/diff/1/content/browser/renderer_host/backing_store_aura.cc File content/browser/renderer_host/backing_store_aura.cc (right): https://codereview.chromium.org/12389084/diff/1/content/browser/renderer_host/backing_store_aura.cc#newcode42 content/browser/renderer_host/backing_store_aura.cc:42: Nit: Remove the extra blank lines. https://codereview.chromium.org/12389084/diff/1/content/browser/renderer_host/backing_store_aura.cc#newcode90 content/browser/renderer_host/backing_store_aura.cc:90: return ...
7 years, 9 months ago (2013-03-08 04:27:36 UTC) #3
kevers
https://codereview.chromium.org/12389084/diff/1/content/browser/renderer_host/backing_store_aura.cc File content/browser/renderer_host/backing_store_aura.cc (right): https://codereview.chromium.org/12389084/diff/1/content/browser/renderer_host/backing_store_aura.cc#newcode42 content/browser/renderer_host/backing_store_aura.cc:42: On 2013/03/08 04:27:36, pkotwicz wrote: > Nit: Remove the ...
7 years, 9 months ago (2013-03-08 15:20:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12389084/6001
7 years, 9 months ago (2013-03-08 15:21:15 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-08 15:23:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12389084/17001
7 years, 9 months ago (2013-03-08 18:22:03 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-08 18:28:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12389084/17001
7 years, 9 months ago (2013-03-11 12:38:26 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 13:50:02 UTC) #10
Message was sent while issue was closed.
Change committed as 187289

Powered by Google App Engine
This is Rietveld 408576698