Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12389083: cros: Add app mode restrictions. (Closed)

Created:
7 years, 9 months ago by xiyuan
Modified:
7 years, 9 months ago
Reviewers:
zel, sky
CC:
chromium-reviews, Avi (use Gerrit), sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, tfarina, mazda+watch_chromium.org, ajwong+watch_chromium.org, creis+watch_chromium.org
Visibility:
Public.

Description

cros: Add app mode restrictions. - White list ash accelerator actions; - White list browser accelerators; - Use a limited render view context menu; BUG=178469 TEST=Verify Ctrl-N etc is disabled and no accelerator/menu to get a browser window in app mode. R=zelidrag@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186214

Patch Set 1 #

Patch Set 2 : lint fix #

Total comments: 2

Patch Set 3 : for comments in #1 #

Total comments: 4

Patch Set 4 : for comments in #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -20 lines) Patch
M ash/accelerators/accelerator_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M ash/shell_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M ash/test/test_shell_delegate.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/app_mode/app_mode_utils.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/app_mode/app_mode_utils.cc View 1 chunk +37 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 12 chunks +33 lines, -14 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
xiyuan
7 years, 9 months ago (2013-03-04 20:42:25 UTC) #1
zel
lgtm
7 years, 9 months ago (2013-03-04 21:05:04 UTC) #2
tfarina
https://codereview.chromium.org/12389083/diff/2001/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (right): https://codereview.chromium.org/12389083/diff/2001/chrome/browser/tab_contents/render_view_context_menu.cc#newcode529 chrome/browser/tab_contents/render_view_context_menu.cc:529: bool has_selection = !params_.selection_text.empty(); do you want to avoid ...
7 years, 9 months ago (2013-03-04 21:07:58 UTC) #3
xiyuan
https://codereview.chromium.org/12389083/diff/2001/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (right): https://codereview.chromium.org/12389083/diff/2001/chrome/browser/tab_contents/render_view_context_menu.cc#newcode529 chrome/browser/tab_contents/render_view_context_menu.cc:529: bool has_selection = !params_.selection_text.empty(); On 2013/03/04 21:07:58, tfarina wrote: ...
7 years, 9 months ago (2013-03-04 21:55:31 UTC) #4
sky
https://codereview.chromium.org/12389083/diff/8002/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): https://codereview.chromium.org/12389083/diff/8002/chrome/browser/ui/views/frame/browser_view.cc#newcode2464 chrome/browser/ui/views/frame/browser_view.cc:2464: #if defined(OS_CHROMEOS) Don't we want this when in ash ...
7 years, 9 months ago (2013-03-04 22:25:14 UTC) #5
xiyuan
https://codereview.chromium.org/12389083/diff/8002/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): https://codereview.chromium.org/12389083/diff/8002/chrome/browser/ui/views/frame/browser_view.cc#newcode2464 chrome/browser/ui/views/frame/browser_view.cc:2464: #if defined(OS_CHROMEOS) On 2013/03/04 22:25:14, sky wrote: > Don't ...
7 years, 9 months ago (2013-03-04 22:38:31 UTC) #6
sky
LGTM
7 years, 9 months ago (2013-03-05 01:21:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/12389083/2005
7 years, 9 months ago (2013-03-05 03:20:32 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=118228
7 years, 9 months ago (2013-03-05 08:36:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/12389083/2005
7 years, 9 months ago (2013-03-05 15:23:34 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 18:51:50 UTC) #11
Message was sent while issue was closed. 
Change committed as 186214

Powered by Google App Engine
This is Rietveld 408576698