Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 12389079: Disable content pack buttons. (Closed)

Created:
7 years, 9 months ago by Sergiu
Modified:
7 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, Adrian Kuegel, Bernhard Bauer
Visibility:
Public.

Description

Disable content pack buttons. The buttons currently provide no functionality so disable them for now. BUG=171370 R=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186205

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Multiline tags should close on new line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/resources/managed_mode_block_interstitial.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/managed_user_settings.html View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/options/managed_user_settings.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergiu
7 years, 9 months ago (2013-03-04 15:27:13 UTC) #1
James Hawkins
Can we hide them instead?
7 years, 9 months ago (2013-03-04 18:43:43 UTC) #2
Sergiu
We thought that it would be better to disable them as the hopefully the functionality ...
7 years, 9 months ago (2013-03-04 20:20:59 UTC) #3
James Hawkins
On 2013/03/04 20:20:59, Sergiu wrote: > We thought that it would be better to disable ...
7 years, 9 months ago (2013-03-04 20:26:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiu@chromium.org/12389079/9001
7 years, 9 months ago (2013-03-05 12:11:23 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 9 months ago (2013-03-05 18:15:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiu@chromium.org/12389079/9001
7 years, 9 months ago (2013-03-05 18:17:05 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 18:19:27 UTC) #8
Message was sent while issue was closed.
Change committed as 186205

Powered by Google App Engine
This is Rietveld 408576698