Extend grokdump with support for maps, transition and descriptor arrays.

Extend grokdump with support for maps, transition and descriptor arrays.

Committed: https://code.google.com/p/v8/source/detail?r=13845

[Toon Verwaest, 2013-03-04 13:26:51]

PTAL

[Michael Starzinger, 2013-03-05 16:14:57]

Oh yeah, more grokdump goodness. Me gusta!

https://codereview.chromium.org/12389077/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

https://codereview.chromium.org/12389077/diff/1/tools/grokdump.py#newcode1467
tools/grokdump.py:1467: print "[%i] details: %s %s enum %i pointer %i" %
self.Details(di, array.Get(i + 1))
Longer than 80 characters.

https://codereview.chromium.org/12389077/diff/1/tools/grokdump.py#newcode2010
tools/grokdump.py:2010: def do_desc(self, address):
Can we rename these commands to have a common prefix? For exmaple "do_desc",
"do_trans" and "do_map" (where "do" mean "dump object"). That would be in line
with the "do" command we already have. Also can we then alpha-sort the commands?

[Toon Verwaest, 2013-03-06 15:24:11]

addressed comments

https://chromiumcodereview.appspot.com/12389077/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

https://chromiumcodereview.appspot.com/12389077/diff/1/tools/grokdump.py#newc...
tools/grokdump.py:1467: print "[%i] details: %s %s enum %i pointer %i" %
self.Details(di, array.Get(i + 1))
On 2013/03/05 16:14:57, Michael Starzinger wrote:
> Longer than 80 characters.

Done.

https://chromiumcodereview.appspot.com/12389077/diff/1/tools/grokdump.py#newc...
tools/grokdump.py:2010: def do_desc(self, address):
On 2013/03/05 16:14:57, Michael Starzinger wrote:
> Can we rename these commands to have a common prefix? For exmaple "do_desc",
> "do_trans" and "do_map" (where "do" mean "dump object"). That would be in line
> with the "do" command we already have. Also can we then alpha-sort the
commands?

Done.

[Michael Starzinger, 2013-03-06 15:34:36]

LGTM.

[Toon Verwaest, 2013-03-06 17:06:52]

Committed patchset #2 manually as r13845 (presubmit successful).