tools/perf/perf_tools/histogram_metric.py - Issue 12389073: Collect tab timing information for use in telementry-based startup tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/perf_tools/histogram_metric.py

Issue 12389073: Collect tab timing information for use in telementry-based startup tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix telemetry tests with reference builds. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/perf_tools/histogram_metric.py

diff --git a/tools/perf/perf_tools/histogram_metric.py b/tools/perf/perf_tools/histogram_metric.py

index d05394ec1b69f2b83e4ecffc65045954fde3631d..1df72571fac32d4ff17b64ebec6bf0584c05d309 100644

--- a/tools/perf/perf_tools/histogram_metric.py

+++ b/tools/perf/perf_tools/histogram_metric.py

@@ -36,7 +36,10 @@ class HistogramMetric(object):

return 'getHistogram'

def _GetHistogramFromDomAutomation(self, tab):

- js = ('window.domAutomationController.%s ? '

- 'window.domAutomationController.%s("%s") : ""' %

tonyg 2013/05/29 15:39:00 Looks like we lost the branch where neither domAut

- (self.histogram_function, self.histogram_function, self.name))

+ # TODO(jeremy): Remove references to

+ # domAutomationController when we update the reference builds.

+ js = ('(window.statsCollectionController ? '

+ 'statsCollectionController : '

+ 'domAutomationController).%s("%s")' %

+ (self.histogram_function, self.name))

return tab.EvaluateJavaScript(js)

« no previous file with comments | « content/renderer/stats_collection_observer.cc ('k') | tools/perf/perf_tools/memory_measurement.py » ('j') | no next file with comments »