Rename DumpAccesibilityTreeHelper to AccessibilityTreeFormatter, pull into content/browser.

Rename DumpAccesibilityTreeHelper to AccessibilityTreeFormatter, pull into content/browser.

BUG=178756
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186229

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186476

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186590

[dmazzoni, 2013-02-28 18:59:11]

No concerns, just some minor details

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
File content/browser/accessibility/accessibility_tree_formatter.h (right):

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
content/browser/accessibility/accessibility_tree_formatter.h:5: #ifndef
CONTENT_BROWSER_ACCESSIBILITY_ACCESSIBILITY_TREE_FORMATTER_IMPL_H_
Get rid of _IMPL

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
File content/browser/accessibility/accessibility_tree_formatter_utils_win.h
(right):

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
content/browser/accessibility/accessibility_tree_formatter_utils_win.h:5:
#ifndef CONTENT_PUBLIC_TEST_ACCESSIBILITY_TEST_UTILS_WIN_H_
Update this

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:24:
#include "content/public/common/accessibility_mode.h"
This doesn't exist anymore, right?

https://codereview.chromium.org/12389028/diff/2001/content/content_browser.gypi
File content/content_browser.gypi (right):

https://codereview.chromium.org/12389028/diff/2001/content/content_browser.gy...
content/content_browser.gypi:202:
'browser/accessibility/accessibility_tree_formatter.cc',
These additions aren't in the right sorted order in the file

https://codereview.chromium.org/12389028/diff/2001/content/public/test/access...
File content/public/test/accessibility_test_utils_win.cc (left):

https://codereview.chromium.org/12389028/diff/2001/content/public/test/access...
content/public/test/accessibility_test_utils_win.cc:5: #include
"content/public/test/accessibility_test_utils_win.h"
I don't see these files removed from a gyp file

[aboxhall, 2013-02-28 22:12:58]

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
File content/browser/accessibility/accessibility_tree_formatter.h (right):

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
content/browser/accessibility/accessibility_tree_formatter.h:5: #ifndef
CONTENT_BROWSER_ACCESSIBILITY_ACCESSIBILITY_TREE_FORMATTER_IMPL_H_
On 2013/02/28 18:59:12, Dominic Mazzoni wrote:
> Get rid of _IMPL

Done.

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
File content/browser/accessibility/accessibility_tree_formatter_utils_win.h
(right):

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
content/browser/accessibility/accessibility_tree_formatter_utils_win.h:5:
#ifndef CONTENT_PUBLIC_TEST_ACCESSIBILITY_TEST_UTILS_WIN_H_
On 2013/02/28 18:59:12, Dominic Mazzoni wrote:
> Update this

Done.

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/12389028/diff/2001/content/browser/accessibil...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:24:
#include "content/public/common/accessibility_mode.h"
On 2013/02/28 18:59:12, Dominic Mazzoni wrote:
> This doesn't exist anymore, right?

Done.

https://codereview.chromium.org/12389028/diff/2001/content/content_browser.gypi
File content/content_browser.gypi (right):

https://codereview.chromium.org/12389028/diff/2001/content/content_browser.gy...
content/content_browser.gypi:202:
'browser/accessibility/accessibility_tree_formatter.cc',
On 2013/02/28 18:59:12, Dominic Mazzoni wrote:
> These additions aren't in the right sorted order in the file

Done.

https://codereview.chromium.org/12389028/diff/2001/content/content_browser.gy...
content/content_browser.gypi:202:
'browser/accessibility/accessibility_tree_formatter.cc',
On 2013/02/28 18:59:12, Dominic Mazzoni wrote:
> These additions aren't in the right sorted order in the file

Done.

https://codereview.chromium.org/12389028/diff/2001/content/public/test/access...
File content/public/test/accessibility_test_utils_win.cc (left):

https://codereview.chromium.org/12389028/diff/2001/content/public/test/access...
content/public/test/accessibility_test_utils_win.cc:5: #include
"content/public/test/accessibility_test_utils_win.h"
On 2013/02/28 18:59:12, Dominic Mazzoni wrote:
> I don't see these files removed from a gyp file

Done.

[dmazzoni, 2013-02-28 22:19:28]

LGTM

Looks like you need to update
content/browser/accessibility/accessibility_win_browsertest.cc also, since it
also includes accessibility_test_utils_win.h.

[commit-bot: I haz the power, 2013-03-01 02:11:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/14

[commit-bot: I haz the power, 2013-03-01 02:11:08]

Failed to apply patch for
content/browser/accessibility/accessibility_win_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/accessibility/accessibility_win_browsertest.cc
  Hunk #1 FAILED at 9.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/accessibility/accessibility_win_browsertest.cc.rej

Patch:       content/browser/accessibility/accessibility_win_browsertest.cc
Index: content/browser/accessibility/accessibility_win_browsertest.cc
diff --git a/content/browser/accessibility/accessibility_win_browsertest.cc
b/content/browser/accessibility/accessibility_win_browsertest.cc
index
b79008d8d2ec1fb8a190b3ab4ab217ac2db709f7..73dce76e2bb45abea0c2c138ab3c5ece7c12ebed
100644
--- a/content/browser/accessibility/accessibility_win_browsertest.cc
+++ b/content/browser/accessibility/accessibility_win_browsertest.cc
@@ -9,13 +9,13 @@
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/scoped_comptr.h"
+#include
"content/browser/accessibility/accessibility_tree_formatter_utils_win.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
-#include "content/public/test/accessibility_test_utils_win.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/shell.h"
 #include "content/test/content_browser_test.h"

[commit-bot: I haz the power, 2013-03-01 23:30:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/16

[commit-bot: I haz the power, 2013-03-01 23:30:42]

Presubmit check for 12389028-16 failed and returned exit status 1.

INFO:root:Found 10 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/content_tests.gypi
    content/content_browser.gypi

Presubmit checks took 1.4s to calculate.

[aboxhall, 2013-03-01 23:32:29]

John, would you be able to take a look at the gypi changes?

[jam, 2013-03-04 04:03:39]

lgtm

https://codereview.chromium.org/12389028/diff/16/content/browser/accessibilit...
File content/browser/accessibility/accessibility_tree_formatter.cc (right):

https://codereview.chromium.org/12389028/diff/16/content/browser/accessibilit...
content/browser/accessibility/accessibility_tree_formatter.cc:34:
content::BrowserAccessibilityManager* manager =
nit: here and below, no "content::"

[aboxhall, 2013-03-04 17:36:11]

https://codereview.chromium.org/12389028/diff/16/content/browser/accessibilit...
File content/browser/accessibility/accessibility_tree_formatter.cc (right):

https://codereview.chromium.org/12389028/diff/16/content/browser/accessibilit...
content/browser/accessibility/accessibility_tree_formatter.cc:34:
content::BrowserAccessibilityManager* manager =
On 2013/03/04 04:03:39, jam wrote:
> nit: here and below, no "content::"

Done.

[commit-bot: I haz the power, 2013-03-04 17:36:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/16001

[commit-bot: I haz the power, 2013-03-04 18:07:50]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[dmazzoni, 2013-03-04 18:25:34]

https://codereview.chromium.org/12389028/diff/7024/content/browser/accessibil...
File content/browser/accessibility/accessibility_tree_formatter.h (right):

https://codereview.chromium.org/12389028/diff/7024/content/browser/accessibil...
content/browser/accessibility/accessibility_tree_formatter.h:23: class
AccessibilityTreeFormatter {
I think you might need CONTENT_EXPORT here.

Previously, this file was only used by tests, and was compiled as part of the
"test" dll.

Now it's part of content, but needs to be linked by the tests dll.

[commit-bot: I haz the power, 2013-03-04 20:04:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/4013

[commit-bot: I haz the power, 2013-03-04 20:19:26]

Retried try job too often on linux_chromeos for step(s) browser_tests,
content_browsertests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-04 22:05:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/1041

[commit-bot: I haz the power, 2013-03-05 16:54:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/10014

[commit-bot: I haz the power, 2013-03-05 19:36:45]

Change committed as 186229

[commit-bot: I haz the power, 2013-03-06 17:16:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/33003

[commit-bot: I haz the power, 2013-03-06 17:52:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/33003

[commit-bot: I haz the power, 2013-03-06 19:26:37]

Change committed as 186476

[commit-bot: I haz the power, 2013-03-06 21:47:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/12389028/46004

[commit-bot: I haz the power, 2013-03-07 02:13:44]

Change committed as 186590