Added function DeleteOriginDirectory to RemoteFileSyncService interface that removes the remote cop…

Added function DeleteOriginDirectory to RemoteFileSyncService interface that removes the remote copy of data for a particular extension. Implementation is in DriveFileSyncService.cc. Will hook this up to DeleteFileSystem and Uninstall notification mechanism next.

BUG=177387
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186185

[calvinlo, 2013-02-28 09:22:41]

Here's my idea for testing this patch

In a separate small patch before this:
Add a private set<ResourceID> that records every file that is supposed to be
deleted.
Implement DeleteFile in FakeDriveFileSyncService such that every time it's
called, the resourceID is added to the map

Then adding a unit test for this patch:
// Add to drive metadata store GURL->ResourceID, return <BLAH123>
// DriveFileSyncService calls deleteOriginDirectory(GURL)
// Assert that FakeDriveFileSyncService deletedSet<ResourceID> contains
<BLAH123>

[tzik, 2013-03-01 05:16:51]

lgtm

[tzik, 2013-03-05 07:17:21]

Let me delete broken patch.
The upload sometimes fails when we refer the base file while the upload is in
progress.

[calvinlo, 2013-03-05 13:20:26]

Just to note the discussion that happened between myself and tzik. This patch
will be landed first with the test being added later.

There will then be 3 tests for drive_file_sync_service.cc
1. drive_file_sync_service_mock_unittests.cc which will be a rename of the
original test file drive_file_sync_service_unittests.cc. The idea is to
eventually move away from gMock used in these tests and to use the fake*
instead.
2. drive_file_sync_service_sync_unittests.cc will contain the composite tests
tzik has created using his new framework.
3. drive_file_sync_service_unittests.cc will be the new unittest file that uses
FakeDriveFileSyncClient.

In a separate patch, I will do the rename for #1 so that the name operation and
gypi change are isolated for the reviewer.

[tzik, 2013-03-05 13:31:01]

lgtm

[commit-bot: I haz the power, 2013-03-05 13:54:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/12389017/30001

[commit-bot: I haz the power, 2013-03-05 16:17:01]

Change committed as 186185