Matching modes for mirroring should preserve interlacing.

Matching modes for mirroring should preserve interlacing.

Add a condition when searching for modes for mirroring -
both modes must either be interlaced or progressive scan.

Also, as internal panels don't support interlacing,
do not attempt to panel fit interlaced modes on them.

BUG=179207
TEST=Manually disabled modes, making interlaced one the preferred,
     then verified that this mode is not picked for mirroring,
     but the next one. Steps in the bug should also work,
     but I don't have the necessary hardware.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186231

[oshima, 2013-03-05 00:32:18]

lgtm

[ynovikov, 2013-03-05 00:34:24]

On 2013/03/05 00:32:18, oshima wrote:
> lgtm

Thank you.

[marcheu, 2013-03-05 00:48:47]

https://codereview.chromium.org/12388090/diff/1/chromeos/display/output_confi...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/12388090/diff/1/chromeos/display/output_confi...
chromeos/display/output_configurator.cc:1064: continue;  // Disallow interlaced
modes for mirroring
Isn't the correct thing to check if external and internal have different
interlacing flags? In theory you could interlace and mirror provided both modes
interlace.

[ynovikov, 2013-03-05 01:59:56]

https://codereview.chromium.org/12388090/diff/1/chromeos/display/output_confi...
File chromeos/display/output_configurator.cc (right):

https://codereview.chromium.org/12388090/diff/1/chromeos/display/output_confi...
chromeos/display/output_configurator.cc:1064: continue;  // Disallow interlaced
modes for mirroring
On 2013/03/05 00:48:47, marcheu wrote:
> Isn't the correct thing to check if external and internal have different
> interlacing flags? In theory you could interlace and mirror provided both
modes
> interlace.

Done.
Though the correct thing is more complex than you describe - you only refer to
finding matching resolutions, but when none are found, panel fitting may be
used. So, I assume that in panel fitting we are dealing with internal panel that
doesn't support interlacing, and skip interlaced modes then.
This will allow us to have 2 monitors connected to Stumpy in interlaced mode.
Thanks for catching!

[marcheu, 2013-03-05 04:40:54]

lgtm

[commit-bot: I haz the power, 2013-03-05 17:23:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ynovikov@chromium.org/12388090/14001

[commit-bot: I haz the power, 2013-03-05 19:39:52]

Change committed as 186231