Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java

Issue 12388038: Android: Remove Surface cruft (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
index cc84195289695e6e500d00e141ecc1ecf0e333a9..4ea75bdf7b623cf5889b5e20a017e3b0556f4564 100644
--- a/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
+++ b/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
@@ -257,24 +257,6 @@ public class SandboxedProcessLauncher {
connection.unbindHighPriority(false);
}
- static void establishSurfacePeer(
- int pid, int type, Surface surface, int primaryID, int secondaryID) {
- Log.d(TAG, "establishSurfaceTexturePeer: pid = " + pid + ", " +
- "type = " + type + ", " +
- "primaryID = " + primaryID + ", " +
- "secondaryID = " + secondaryID);
- ISandboxedProcessService service = SandboxedProcessLauncher.getSandboxedService(pid);
- if (service == null) {
- Log.e(TAG, "Unable to get SandboxedProcessService from pid.");
- return;
- }
- try {
- service.setSurface(type, surface, primaryID, secondaryID);
- } catch (RemoteException e) {
- Log.e(TAG, "Unable to call setSurface: " + e);
- }
- }
-
/**
* This implementation is used to receive callbacks from the remote service.
*/
@@ -288,15 +270,9 @@ public class SandboxedProcessLauncher {
* to use a Handler.
*/
public void establishSurfacePeer(
- int pid, int type, Surface surface, int primaryID, int secondaryID) {
- SandboxedProcessLauncher.establishSurfacePeer(pid, type, surface,
- primaryID, secondaryID);
- // The SandboxProcessService now holds a reference to the
- // Surface's resources, so we release our reference to it now to
- // avoid waiting for the finalizer to get around to it.
- if (surface != null) {
- surface.release();
- }
+ int pid, Surface surface, int primaryID, int secondaryID) {
+ // TODO(sievers): This should call into native and pass the Surface to the
+ // right media player instance.
}
};
};

Powered by Google App Engine
This is Rietveld 408576698