chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm - Issue 12388035: Don't crash when quitting while an extension popup is open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 12388035: Don't crash when quitting while an extension popup is open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: -hax Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

index cd7ad10e3221493210b4b1c78dce081f0d389823..239d3ac19199420bda4bfead1c08cae60d676e3a 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

@@ -201,6 +201,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {

gPopup = nil;

if (host_->view())

host_->view()->set_container(NULL);

+ host_.reset();

}

- (void)windowDidResignKey:(NSNotification*)notification {

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm ('k') | no next file » | no next file with comments »