chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm - Issue 12388035: Don't crash when quitting while an extension popup is open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

Issue 12388035: Don't crash when quitting while an extension popup is open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: -hax Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

index a34a766520e736c968c5bad5b0d461e069452d00..0a435502a0184923a9e9e414c982643e15460a11 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_browsertest.mm

@@ -149,9 +149,5 @@ IN_PROC_BROWSER_TEST_F(ExtensionActionContextMenuTest, RunInspectPopup) {

from:inspectItem];

devtools_attached_observer.Wait();

- // Hide the popup to prevent racy crashes at test cleanup.

- BrowserActionTestUtil test_util(browser());

- test_util.HidePopup();

service->SetBoolean(prefs::kExtensionsUIDeveloperMode, original);

}

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »