Don't crash when quitting while an extension popup is open.

Mac: Don't crash when quitting while an extension popup is open.

BUG=161604
TEST=Follow instructions in bug. Chromium should quit, not crash.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186212

[Nico, 2013-02-28 22:41:41]

Is it possible to write a test for this?

[Yoyo Zhou, 2013-02-28 22:54:02]

On 2013/02/28 22:41:41, Nico wrote:
> Is it possible to write a test for this?

Doubtful. It seems not to affect multi-profile situations (including just
incognito) as consistently, so I don't know that a test that tries to create a
profile and window to go with it and then destroys that profile to close the
popup would actually work.

[Nico, 2013-03-04 11:03:20]

ok, lgtm

[commit-bot: I haz the power, 2013-03-04 15:35:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/12388035/1

[commit-bot: I haz the power, 2013-03-04 15:45:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Yoyo Zhou, 2013-03-04 19:28:21]

This appears to be crashing a browser_test on the bots, but I can't get it to
crash locally (and the stack is not really helpful):

http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/32352/step...

Any thoughts?

[Nico, 2013-03-04 19:31:31]

You can disable a few cores locally and try reproing again. You can ask the
infra guys to tell you how to ssh into a try bot and try to debug there.

[Yoyo Zhou, 2013-03-04 22:10:45]

Looks like it works to disable the hack in that test to avoid crashing
(presumably the same crash that is fixed here).

[commit-bot: I haz the power, 2013-03-04 22:12:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/12388035/6

[commit-bot: I haz the power, 2013-03-05 02:28:05]

Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-03-05 18:00:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/12388035/6

[commit-bot: I haz the power, 2013-03-05 18:41:50]

Change committed as 186212