Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: git_cl.py

Issue 12388027: git cl upload now diffs HEAD rather than working tree (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index e4c3a7154f00770b8b32b853a174597fd217b5df..f3f783932b5dbb389e6330811aeec366cfad57cc 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1272,7 +1272,7 @@ def CMDupload(parser, args):
else:
# Default to diffing against common ancestor of upstream branch
base_branch = RunGit(['merge-base', cl.GetUpstreamBranch(), 'HEAD']).strip()
- args = [base_branch]
+ args = [base_branch, 'HEAD']
if not options.bypass_hooks:
hook_results = cl.RunHook(committing=False, upstream_branch=base_branch,
« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698