Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 12388027: git cl upload now diffs HEAD rather than working tree (Closed)

Created:
7 years, 9 months ago by Sam Clegg
Modified:
7 years, 9 months ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

git cl upload now diffs HEAD rather than working tree BUG=179131 TEST=./tests/git_cl_test.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=185366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/git_cl_test.py View 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
Followup to https://codereview.chromium.org/11839002/
7 years, 9 months ago (2013-02-28 20:02:42 UTC) #1
cmp
On 2013/02/28 20:02:42, Sam Clegg wrote: > Followup to https://codereview.chromium.org/11839002/ Robbie, can you take a ...
7 years, 9 months ago (2013-02-28 23:39:04 UTC) #2
iannucci1
Totally lgtm :) Thanks
7 years, 9 months ago (2013-02-28 23:52:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/12388027/1
7 years, 9 months ago (2013-02-28 23:53:09 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 23:55:45 UTC) #5
Message was sent while issue was closed.
Change committed as 185366

Powered by Google App Engine
This is Rietveld 408576698