Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 12388017: Move the responsibility to convert from JSON to AccountMetadata into gdata_wapi_operations. (Closed)

Created:
7 years, 9 months ago by hidehiko
Modified:
7 years, 9 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, satorux1
Base URL:
http://git.chromium.org/chromium/src.git@b148632_gdata_wapi_get_about_resource_impl
Visibility:
Public.

Description

Move the responsibility to convert from JSON to AccountMetadata into gdata_wapi_operations. These are two purposes of this change. 1) Resolve the asymmetricity of the JSON(or XML) and typed C++ conversion. Now, operation classes take the C++ parameters and format them into JSON/XML. However, the response is converted in GDataWapiService. This CL resolves the asymmetricity for AccountMetadataFeed. 2) This is also the preparation of the GDataWapiService::GetAboutResource and GetAppList implementation. BUG=174237 TEST=Ran unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -35 lines) Patch
M chrome/browser/google_apis/gdata_wapi_operations.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 2 chunks +27 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 2 chunks +19 lines, -7 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 2 chunks +1 line, -25 lines 0 comments Download
M chrome/browser/google_apis/test_util.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/test_util.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 9 months ago (2013-02-28 13:18:41 UTC) #1
kinaba
lgtm
7 years, 9 months ago (2013-03-01 00:56:49 UTC) #2
hashimoto
lgtm
7 years, 9 months ago (2013-03-01 03:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12388017/1
7 years, 9 months ago (2013-03-01 03:58:26 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-01 07:54:28 UTC) #5
Message was sent while issue was closed.
Change committed as 185491

Powered by Google App Engine
This is Rietveld 408576698