Issue 12388015: Fix math.round with SSE4.1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12388015: Fix math.round with SSE4.1. (Closed)

Created:
7 years, 9 months ago by Yang

Modified:
7 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix math.round with SSE4.1. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13771

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

Committed patchset #1 manually as r13771 (presubmit successful).

7 years, 9 months ago (2013-02-28 10:39:40 UTC) #3

Sven Panne

7 years, 9 months ago (2013-03-01 08:12:11 UTC) #4

Message was sent while issue was closed.

Note: This CL causes some very visible performance regressions in Kraken, e.g.
in audio-beat-detection, audio-oscillator and imaging-desaturate, so somebody
should look into this.

Expand Messages | Collapse Messages