Issue 12388012: Ignore the disabled state of component-updated PPAPI Flash for once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12388012: Ignore the disabled state of component-updated PPAPI Flash for once. (Closed)

Created:
7 years, 9 months ago by yzshen1

Modified:
7 years, 9 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, cpu_(ooo_6.6-7.5)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ignore the disabled state of component-updated PPAPI Flash for once. In the early stage of component-updated PPAPI Flash, we did field trials in which it was set to disabled by default. The corresponding settings item might remain in some users' profiles. Currently it affects both the bundled and component-updated PPAPI Flash (since the two share the same enable/disable state). We want to remove this item to get those users to use PPAPI Flash. We will want to do so only once. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185431

Patch Set 1 #

Patch Set 2 : . #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -12 lines)			Patch
M	chrome/browser/plugins/plugin_prefs.cc	View	7 chunks	+49 lines, -12 lines	0 comments	Download
M	chrome/browser/plugins/plugin_prefs_factory.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yzshen1

Hi, Bernhard. Would you please help me to scrutinize this CL? I've done my best ...

7 years, 9 months ago (2013-02-28 05:53:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/12388012/4001

7 years, 9 months ago (2013-02-28 20:21:46 UTC) #3

Message was sent while issue was closed.

Change committed as 185431

Expand Messages | Collapse Messages