Issue 12388011: Two fixes to touch selection:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12388011: Two fixes to touch selection: (Closed)

Created:
7 years, 9 months ago by varunjain

Modified:
7 years, 9 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Two fixes to touch selection: 1. When showing the context menu, pass the correct menu position to the controller. 2. If none of the touch selection end points is in view, dont show the selection menu. Also, NativeTextfieldViews should not show "Select All" option in the menu if there is nothing to select. BUG=115237 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185349

Patch Set 1 : patch #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	ui/views/controls/textfield/native_textfield_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ui/views/touchui/touch_selection_controller_impl.cc	View		2 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/12388011/2001

7 years, 9 months ago (2013-02-28 20:11:45 UTC) #3

Message was sent while issue was closed.

Change committed as 185349

Expand Messages | Collapse Messages