Move the responsibility to convert from JSON to FileResource into drive_api_operations.

Move the responsibility to convert from JSON to FileResource into drive_api_operations.

These are two purposes of this change.
1) Resolve the asymmetricity of the JSON and typed C++ conversion.
Now, operation classes take the C++ parameters and format them into JSON.
However, the response is converted in DriveAPIService. This CL resolves the
asymmetricity for FileResource.
2) This is also the preparation of the ResumeUploadOperation implementation.

BUG=148632
TEST=Ran unit_tests.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185495

[hidehiko, 2013-02-28 19:11:37]

Thank you for your review in advance,
- hidehiko

[kinaba, 2013-03-01 02:22:51]

lgtm

[hashimoto, 2013-03-01 02:29:18]

lgtm with nits

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_operations.h (right):

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations.h:10: #include "base/callback.h"
nit: Can't this be replaced with callback_forward.h?

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_operations_unittest.cc (right):

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations_unittest.cc:265:
EXPECT_EQ("{\"mimeType\":\"application/vnd.google-apps.folder\","
nit: Now we are checking the values parsed from the response below. Why do we
need to check the content as a string here?

[hidehiko, 2013-03-01 03:53:55]

Thank you for your review. Submitting in order...

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_operations.h (right):

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations.h:10: #include "base/callback.h"
On 2013/03/01 02:29:19, hashimoto wrote:
> nit: Can't this be replaced with callback_forward.h?

Done.

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
File chrome/browser/google_apis/drive_api_operations_unittest.cc (right):

https://codereview.chromium.org/12387021/diff/1/chrome/browser/google_apis/dr...
chrome/browser/google_apis/drive_api_operations_unittest.cc:265:
EXPECT_EQ("{\"mimeType\":\"application/vnd.google-apps.folder\","
On 2013/03/01 02:29:19, hashimoto wrote:
> nit: Now we are checking the values parsed from the response below. Why do we
> need to check the content as a string here?

Good catch. It was just my mistake. Removed.

[hashimoto, 2013-03-01 03:55:13]

lgtm

[commit-bot: I haz the power, 2013-03-01 03:58:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12387021/10002

[commit-bot: I haz the power, 2013-03-01 08:07:48]

Change committed as 185495