Make it possible to override the default mipsel sysroot.

Make it possible to override the default mipsel sysroot.

Also, update the default mipsel sysroot to match the work in issue 12315003.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186251

[Mostyn Bramley-Moore, 2013-02-28 09:12:56]

@petarj: Does this look OK to you?  I'm not sure if we need the additional check
for disable_nacl!=1 but we at least need to add the % so sysroot can be
overridden.

[petarj, 2013-03-01 01:29:31]

On 2013/02/28 09:12:56, Mostyn Bramley-Moore wrote:
> @petarj: Does this look OK to you?  I'm not sure if we need the additional
check
> for disable_nacl!=1 but we at least need to add the % so sysroot can be
> overridden.

No, I do not agree with this change. The truth is that we are reusing the
native client sysroot even when disable_nacl=1, but this is only a temporary
solution until we modify the script for building the sysroot and modify the
script for installing it.

You can see some related discussion at:

https://codereview.chromium.org/12315003/

Once that part is changed, we will be changing build/common.gypi,
the line that you have already pinpointed with this CL, and it will
probably be something like:

'sysroot%': '<!(cd <(DEPTH) && pwd -P)/mipsel-sysroot/sysroot'

[Mostyn Bramley-Moore, 2013-03-01 08:42:58]

Are you OK with just making sysroot overridable?

[petarj, 2013-03-04 23:15:10]

On 2013/03/01 08:42:58, Mostyn Bramley-Moore wrote:
> Are you OK with just making sysroot overridable?

If you are already touching this line, change it to:

'sysroot%': '<!(cd <(DEPTH) && pwd -P)/mipsel-sysroot/sysroot'

[Mostyn Bramley-Moore, 2013-03-05 00:08:21]

Done in patch set 3.

[petarj, 2013-03-05 00:21:15]

lgtm, but the change here must be approved by "full super star committer" which
I am not
+ tony as a reviewer.

[tony, 2013-03-05 00:24:42]

The gypi change seems fine, but you should update the change description to say
why we're changing the sysroot path.

[tony, 2013-03-05 00:25:01]

Does this patch depend on https://codereview.chromium.org/12315003/ ?

[petarj, 2013-03-05 00:30:21]

On 2013/03/05 00:25:01, tony wrote:

they are related but one does not block the other one.
I also need to modify install-arm-sysroot.py so it installs mips sysroot
as well, so couple of small changes are related one to another.

[Mostyn Bramley-Moore, 2013-03-05 07:26:13]

On 2013/03/05 00:24:42, tony wrote:
> The gypi change seems fine, but you should update the change description to
say
> why we're changing the sysroot path.

Done.

[Mostyn Bramley-Moore, 2013-03-05 15:20:07]

@tony: are you happy for me to queue this for integration?

[tony, 2013-03-05 18:07:20]

LGTM

[commit-bot: I haz the power, 2013-03-05 18:09:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/12387011/5001

[commit-bot: I haz the power, 2013-03-05 20:50:11]

Change committed as 186251