Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: src/untrusted/irt/check_tls.py

Issue 12386091: Simplify check_tls on ARM, now that llvm emits mapping symbols. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: simplify_more Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/untrusted/irt/check_tls.gypi ('k') | src/untrusted/irt/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/untrusted/irt/check_tls.py
diff --git a/src/untrusted/irt/check_tls.py b/src/untrusted/irt/check_tls.py
index 7aa7d3c826473bdca3c97bae0a341ed532b7c118..a6bffd05890f3e5411d698da01c7d005e08c648a 100644
--- a/src/untrusted/irt/check_tls.py
+++ b/src/untrusted/irt/check_tls.py
@@ -22,8 +22,8 @@ def Main(args):
obj_file = args[2]
whitelist_regex = None
+ objdump_args = [objdump, '-d', obj_file]
if arch == 'x86-32':
- objdump_args = [objdump, '-d', obj_file]
# "%gs:4" is allowed but all other uses of %gs are suspect.
register = '%gs'
regex = re.compile(register + r'(?!:0x4\b)')
@@ -31,13 +31,6 @@ def Main(args):
# Nothing to check.
regex = None
elif arch.startswith('arm'):
- if arch == 'arm-gcc':
- objdump_flags = ['-d']
- elif arch == 'arm-pnacl':
- # TODO(mcgrathr): Just use -d when PNaCl compiler is fixed so it works.
- # See http://code.google.com/p/nativeclient/issues/detail?id=2818
- objdump_flags = ['-D', '--section=.text']
- objdump_args = [objdump] + objdump_flags + [obj_file]
# A real reference to r9 should probably be preceded by some character
# that is not legal for an identifier (e.g., spaces, commas, brackets).
register = 'r9'
« no previous file with comments | « src/untrusted/irt/check_tls.gypi ('k') | src/untrusted/irt/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698