Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Side by Side Diff: src/untrusted/irt/nacl.scons

Issue 12386091: Simplify check_tls on ARM, now that llvm emits mapping symbols. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: simplify_more Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/untrusted/irt/check_tls.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # -*- python -*- 1 # -*- python -*-
2 # Copyright (c) 2012 The Native Client Authors. All rights reserved. 2 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 6
7 Import('env') 7 Import('env')
8 8
9 # TODO(mseaborn): Enable -Wstrict-prototypes here. Currently 9 # TODO(mseaborn): Enable -Wstrict-prototypes here. Currently
10 # dlmalloc/malloc.c does not build with this warning. 10 # dlmalloc/malloc.c does not build with this warning.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 # ensure all TLS accesses use a call to __nacl_read_tp (or __aeabi_read_tp 137 # ensure all TLS accesses use a call to __nacl_read_tp (or __aeabi_read_tp
138 # for ARM), which the IRT code overrides to segregate IRT-private TLS 138 # for ARM), which the IRT code overrides to segregate IRT-private TLS
139 # from user TLS. 139 # from user TLS.
140 if ((env.Bit('build_arm') or env.Bit('build_x86_32')) 140 if ((env.Bit('build_arm') or env.Bit('build_x86_32'))
141 # Do not try to run OBJDUMP if 'built_elsewhere', since that *might* 141 # Do not try to run OBJDUMP if 'built_elsewhere', since that *might*
142 # mean that a toolchain is not even present. E.g., the arm buildbots 142 # mean that a toolchain is not even present. E.g., the arm buildbots
143 # do not have the pnacl toolchain, since that is built for x86 hosts. 143 # do not have the pnacl toolchain, since that is built for x86 hosts.
144 and not env.Bit('built_elsewhere')): 144 and not env.Bit('built_elsewhere')):
145 check_tls_arch = '${TARGET_FULLARCH}' 145 check_tls_arch = '${TARGET_FULLARCH}'
146 if env.Bit('build_arm'): 146 if env.Bit('build_arm'):
147 if env.Bit('bitcode'): 147 check_tls_arch = 'arm'
148 check_tls_arch = 'arm-pnacl'
149 else:
150 check_tls_arch = 'arm-gcc'
151 node = env.CommandTest('irt_core_tls_test.out', 148 node = env.CommandTest('irt_core_tls_test.out',
152 ['${PYTHON}', env.File('check_tls.py'), 149 ['${PYTHON}', env.File('check_tls.py'),
153 check_tls_arch, '${OBJDUMP}', irt_core_library], 150 check_tls_arch, '${OBJDUMP}', irt_core_library],
154 # don't run ${PYTHON} under the emulator. 151 # don't run ${PYTHON} under the emulator.
155 direct_emulation=False) 152 direct_emulation=False)
156 env.AddNodeToTestSuite(node, ['small_tests'], 'run_irt_core_tls_test') 153 env.AddNodeToTestSuite(node, ['small_tests'], 'run_irt_core_tls_test')
OLDNEW
« no previous file with comments | « src/untrusted/irt/check_tls.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698