Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 12386072: Move Arrays class to private library. (Closed)

Created:
7 years, 9 months ago by floitsch
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 80chars and fix dart2js #

Patch Set 3 : Rebase after revert. #

Total comments: 2

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -200 lines) Patch
M runtime/lib/byte_array.dart View 1 2 34 chunks +57 lines, -38 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M runtime/lib/simd128.dart View 1 3 chunks +5 lines, -3 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 2 1 chunk +14 lines, -1 line 0 comments Download
A + sdk/lib/_collection_dev/arrays.dart View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/_collection_dev/collection_dev.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_collection_dev/collection_dev_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 2 3 chunks +27 lines, -20 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D sdk/lib/collection/arrays.dart View 1 chunk +0 lines, -94 lines 0 comments Download
M sdk/lib/collection/collection.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/collection/collection_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/collection/collections.dart View 1 2 3 1 chunk +26 lines, -4 lines 0 comments Download
M tests/language/list_test.dart View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
floitsch
7 years, 9 months ago (2013-03-02 22:29:12 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 9 months ago (2013-03-04 08:30:26 UTC) #2
floitsch
Committed patchset #2 manually as r19375 (presubmit successful).
7 years, 9 months ago (2013-03-04 10:31:17 UTC) #3
floitsch
Adding srdjan as reviewer.
7 years, 9 months ago (2013-03-04 21:31:24 UTC) #4
Jennifer Messerly
Hey! Glad to see Arrays moving away :) One question, how do I access the ...
7 years, 9 months ago (2013-03-04 21:40:57 UTC) #5
floitsch
On 2013/03/04 21:40:57, John Messerly wrote: > Hey! Glad to see Arrays moving away :) ...
7 years, 9 months ago (2013-03-04 21:50:16 UTC) #6
srdjan
lgtm https://codereview.chromium.org/12386072/diff/7001/sdk/lib/collection/collections.dart File sdk/lib/collection/collections.dart (right): https://codereview.chromium.org/12386072/diff/7001/sdk/lib/collection/collections.dart#newcode378 sdk/lib/collection/collections.dart:378: if (startFrom is! int) throw new ArgumentError(startFrom); Please ...
7 years, 9 months ago (2013-03-04 21:51:49 UTC) #7
floitsch
https://codereview.chromium.org/12386072/diff/7001/sdk/lib/collection/collections.dart File sdk/lib/collection/collections.dart (right): https://codereview.chromium.org/12386072/diff/7001/sdk/lib/collection/collections.dart#newcode378 sdk/lib/collection/collections.dart:378: if (startFrom is! int) throw new ArgumentError(startFrom); On 2013/03/04 ...
7 years, 9 months ago (2013-03-05 13:24:38 UTC) #8
floitsch
7 years, 9 months ago (2013-03-05 13:25:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r19476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698