Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12386035: Moving host status events monitoring to a separate interface (HostStatusMonitor). (Closed)

Created:
7 years, 9 months ago by alexeypa (please no reviews)
Modified:
7 years, 9 months ago
Reviewers:
rmsousa, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, sail+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Moving host status events monitoring to a separate interface (HostStatusMonitor). This CL unbinds the host status event observers from ChromotingHost. This is useful when, for instance, an observer resides in a different process where ChromotingHost is not available. Additionally, observers get HostStatusMonitor as a weak pointer, making sure that they do not need to worry about HostStatusMonitor's life time. BUG=178873 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185684

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added HostStatusMonitorFake. #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -80 lines) Patch
M remoting/host/chromoting_host.h View 5 chunks +12 lines, -4 lines 0 comments Download
M remoting/host/chromoting_host.cc View 2 chunks +4 lines, -1 line 0 comments Download
M remoting/host/curtaining_host_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/curtaining_host_observer.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M remoting/host/host_event_logger.h View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/host/host_event_logger_posix.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M remoting/host/host_event_logger_win.cc View 6 chunks +13 lines, -10 lines 0 comments Download
A remoting/host/host_status_monitor.h View 1 chunk +24 lines, -0 lines 0 comments Download
A remoting/host/host_status_monitor_fake.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
M remoting/host/log_to_server.h View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/log_to_server.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M remoting/host/log_to_server_unittest.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M remoting/host/resizing_host_observer.h View 2 chunks +6 lines, -5 lines 0 comments Download
M remoting/host/resizing_host_observer.cc View 1 1 chunk +8 lines, -9 lines 0 comments Download
M remoting/host/resizing_host_observer_unittest.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download
M remoting/remoting.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
alexeypa (please no reviews)
Renato, please take a look. Jamie, please rubber stamp as needed.
7 years, 9 months ago (2013-02-28 23:27:08 UTC) #1
rmsousa
https://codereview.chromium.org/12386035/diff/1/remoting/host/log_to_server.cc File remoting/host/log_to_server.cc (left): https://codereview.chromium.org/12386035/diff/1/remoting/host/log_to_server.cc#oldcode35 remoting/host/log_to_server.cc:35: host_->AddStatusObserver(this); Nit: now that it's a separate, much simpler ...
7 years, 9 months ago (2013-03-01 01:41:05 UTC) #2
alexeypa (please no reviews)
PTAL. https://codereview.chromium.org/12386035/diff/1/remoting/host/log_to_server.cc File remoting/host/log_to_server.cc (left): https://codereview.chromium.org/12386035/diff/1/remoting/host/log_to_server.cc#oldcode35 remoting/host/log_to_server.cc:35: host_->AddStatusObserver(this); On 2013/03/01 01:41:06, rmsousa wrote: > Nit: ...
7 years, 9 months ago (2013-03-01 17:49:25 UTC) #3
rmsousa
lgtm lgtm
7 years, 9 months ago (2013-03-01 17:56:42 UTC) #4
Jamie
Rubber-stamp LGTM.
7 years, 9 months ago (2013-03-01 18:03:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12386035/6004
7 years, 9 months ago (2013-03-01 18:11:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12386035/6004
7 years, 9 months ago (2013-03-02 03:15:48 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-02 04:27:51 UTC) #8
Message was sent while issue was closed. 
Change committed as 185684

Powered by Google App Engine
This is Rietveld 408576698