Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 12385081: Replace GetAccountMetadata by GetAboutResource in sync_file_system. (Closed)

Created:
7 years, 9 months ago by hidehiko
Modified:
7 years, 9 months ago
Reviewers:
tzik, hashimoto, kinaba
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, satorux1
Base URL:
http://git.chromium.org/chromium/src.git@b174237_gdata_wapi_get_about_resource_impl4
Visibility:
Public.

Description

Replace GetAccountMetadata by GetAboutResource in sync_file_system. GetAboutResource is supported by both GData WAPI and Drive API v2, while GetAccountMetadata is now only supported by GData WAPI. To prepare Drive API v2 migration, replace GetAccountMetadata by GetAboutResource. Note that GetAboutResource doesn't include installed third party application info, but fortunately it is not used in sync file system so we don't need to take care about it. BUG=174237 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186194

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -39 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_client.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_client_unittest.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc View 7 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 9 months ago (2013-03-04 14:24:28 UTC) #1
kinaba
lgtm, but defer the final decision naturally to tzik@
7 years, 9 months ago (2013-03-04 22:50:37 UTC) #2
tzik
lgtm
7 years, 9 months ago (2013-03-05 07:15:45 UTC) #3
hidehiko
On 2013/03/05 07:15:45, tzik wrote: > lgtm Kazuhiro, Taiju, thank you for your review! Ryo, ...
7 years, 9 months ago (2013-03-05 12:45:44 UTC) #4
hashimoto
lgtm
7 years, 9 months ago (2013-03-05 14:05:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12385081/2001
7 years, 9 months ago (2013-03-05 14:05:49 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 17:20:35 UTC) #7
Message was sent while issue was closed.
Change committed as 186194

Powered by Google App Engine
This is Rietveld 408576698