Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12385063: Have valgrind use a gdb that matches the word width of the binary. (Closed)

Created:
7 years, 9 months ago by Jeffrey Yasskin
Modified:
7 years, 9 months ago
Reviewers:
chrome-valgrind-team
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Have valgrind use a gdb that matches the word width of the binary. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186230

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M tools/valgrind/valgrind.sh View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jeffrey Yasskin
7 years, 9 months ago (2013-03-02 00:40:41 UTC) #1
Alexander Potapenko
On 2013/03/02 00:40:41, Jeffrey Yasskin wrote: LGTM if this works.
7 years, 9 months ago (2013-03-05 11:11:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/12385063/1
7 years, 9 months ago (2013-03-05 17:06:50 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 19:39:39 UTC) #4
Message was sent while issue was closed. 
Change committed as 186230

Powered by Google App Engine
This is Rietveld 408576698