Issue 12383065: Remove old-checkbox-style flag, code and assets

Issue 12383065: Remove old-checkbox-style flag, code and assets (Closed)

Created:
7 years, 9 months ago by Rick Byers

Modified:
7 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove old-checkbox-style flag, code and assets BUG=133991 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186915

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix whitespace and merge with trunk #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -156 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/chrome_restart_request.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/ui_base_switches.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/ui_base_switches.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/native_theme/native_theme_base.h	View		1 chunk	+2 lines, -23 lines	0 comments	Download
M	ui/native_theme/native_theme_base.cc	View	1	2 chunks	+30 lines, -99 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-checkbox-disabled-indeterminate.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-checkbox-disabled-off.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-checkbox-disabled-on.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-checkbox-indeterminate.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-checkbox-off.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-checkbox-on.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-radio-disabled-off.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-radio-disabled-on.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-radio-off.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	ui/resources/default_100_percent/linux/linux-radio-on.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ui/resources/ui_resources.grd	View	1	2 chunks	+0 lines, -25 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Rick Byers

Scott, Awhile back you reviewed adding the new checkbox style. This CL just removes the ...

7 years, 9 months ago (2013-03-05 15:28:37 UTC) #1

sky

Fix the spacing and LGTM https://codereview.chromium.org/12383065/diff/1/ui/native_theme/native_theme_base.cc File ui/native_theme/native_theme_base.cc (right): https://codereview.chromium.org/12383065/diff/1/ui/native_theme/native_theme_base.cc#newcode480 ui/native_theme/native_theme_base.cc:480: // Draw the checkmark ...

7 years, 9 months ago (2013-03-05 17:01:00 UTC) #2

Rick Byers

On 2013/03/05 17:01:00, sky wrote: > Fix the spacing and LGTM > > https://codereview.chromium.org/12383065/diff/1/ui/native_theme/native_theme_base.cc > ...

7 years, 9 months ago (2013-03-08 02:53:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/12383065/12002

7 years, 9 months ago (2013-03-08 03:08:54 UTC) #4

Message was sent while issue was closed.

Change committed as 186915

Expand Messages | Collapse Messages