ChromeOS: Enable gold linker flags.

ChromeOS: Enable gold linker flags.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190623

[Lei Zhang, 2013-03-01 02:17:48]

I don't know why this was disabled before, but the cros trybots passes, so shall
we give it another shot?

[Evan Martin, 2013-03-04 07:43:21]

Can you look at the review history?  My recollection is they couldn't use
gold for some reason.


On Thu, Feb 28, 2013 at 6:17 PM, <thestig@chromium.org> wrote:

> Reviewers: Evan Martin,
>
> Message:
> I don't know why this was disabled before, but the cros trybots passes, so
> shall
> we give it another shot?
>
> Description:
> ChromeOS: Enable gold linker flags.
>
> Please review this at
https://codereview.chromium.**org/12383041/<https://codereview.chromium.org/1...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>   M     build/common.gypi
>
>
> Index: build/common.gypi
> ==============================**==============================**=======
> --- build/common.gypi   (revision 185398)
> +++ build/common.gypi   (working copy)
> @@ -570,9 +570,8 @@
>          }],
>
>          # linux_use_gold_flags: whether to use build flags that rely on
> gold.
> -        # On by default for x64 Linux.  Temporarily off for ChromeOS as
> -        # it failed on a buildbot.
> -        ['OS=="linux" and target_arch=="x64" and chromeos==0', {
> +        # On by default for x64 Linux.
> +        ['OS=="linux" and target_arch=="x64"', {
>            'linux_use_gold_flags%': 1,
>          }, {
>            'linux_use_gold_flags%': 0,
>
>
>

[Lei Zhang, 2013-03-25 22:29:35]

Ah ha, here's the mysterious reason. Do we want to try again and see?

Revision 121264
Modified Thu Feb 9 19:26:27 2012 UTC (13 months, 2 weeks ago) by
evan@chromium.org 
File length: 107996 byte(s) 
Diff to previous 121257
Build fix: no gold on any ChromeOS build.

On a Google-internal ChromeOS builder make seems to exit with a
failure code no error message I can identify.

On 2013/03/04 07:43:21, Evan Martin wrote:
> Can you look at the review history?  My recollection is they couldn't use
> gold for some reason.
> 
> 
> On Thu, Feb 28, 2013 at 6:17 PM, <mailto:thestig@chromium.org> wrote:
> 
> > Reviewers: Evan Martin,
> >
> > Message:
> > I don't know why this was disabled before, but the cros trybots passes, so
> > shall
> > we give it another shot?
> >
> > Description:
> > ChromeOS: Enable gold linker flags.
> >
> > Please review this at
>
https://codereview.chromium.**org/12383041/%3Chttps://codereview.chromium.org...>
> >
> > SVN Base: svn://chrome-svn/chrome/trunk/**src/
> >
> > Affected files:
> >   M     build/common.gypi
> >
> >
> > Index: build/common.gypi
> > ==============================**==============================**=======
> > --- build/common.gypi   (revision 185398)
> > +++ build/common.gypi   (working copy)
> > @@ -570,9 +570,8 @@
> >          }],
> >
> >          # linux_use_gold_flags: whether to use build flags that rely on
> > gold.
> > -        # On by default for x64 Linux.  Temporarily off for ChromeOS as
> > -        # it failed on a buildbot.
> > -        ['OS=="linux" and target_arch=="x64" and chromeos==0', {
> > +        # On by default for x64 Linux.
> > +        ['OS=="linux" and target_arch=="x64"', {
> >            'linux_use_gold_flags%': 1,
> >          }, {
> >            'linux_use_gold_flags%': 0,
> >
> >
> >

[Evan Martin, 2013-03-25 22:41:39]

Go for it!


On Mon, Mar 25, 2013 at 3:29 PM, <thestig@chromium.org> wrote:

> Ah ha, here's the mysterious reason. Do we want to try again and see?
>
> Revision 121264
> Modified Thu Feb 9 19:26:27 2012 UTC (13 months, 2 weeks ago) by
> evan@chromium.org
> File length: 107996 byte(s)
> Diff to previous 121257
> Build fix: no gold on any ChromeOS build.
>
> On a Google-internal ChromeOS builder make seems to exit with a
> failure code no error message I can identify.
>
> On 2013/03/04 07:43:21, Evan Martin wrote:
>
>> Can you look at the review history?  My recollection is they couldn't use
>> gold for some reason.
>>
>
>
>  On Thu, Feb 28, 2013 at 6:17 PM, <mailto:thestig@chromium.org> wrote:
>>
>
>  > Reviewers: Evan Martin,
>> >
>> > Message:
>> > I don't know why this was disabled before, but the cros trybots passes,
>> so
>> > shall
>> > we give it another shot?
>> >
>> > Description:
>> > ChromeOS: Enable gold linker flags.
>> >
>> > Please review this at
>>
>
> https://codereview.chromium.****org/12383041/%3Chttps://codere**
> view.chromium.org/12383041/ <http://codereview.chromium.org/12383041/>>
>
>> >
>> > SVN Base: svn://chrome-svn/chrome/trunk/****src/
>> >
>> > Affected files:
>> >   M     build/common.gypi
>> >
>> >
>> > Index: build/common.gypi
>> > ==============================****============================**
>> ==**=======
>> > --- build/common.gypi   (revision 185398)
>> > +++ build/common.gypi   (working copy)
>> > @@ -570,9 +570,8 @@
>> >          }],
>> >
>> >          # linux_use_gold_flags: whether to use build flags that rely on
>> > gold.
>> > -        # On by default for x64 Linux.  Temporarily off for ChromeOS as
>> > -        # it failed on a buildbot.
>> > -        ['OS=="linux" and target_arch=="x64" and chromeos==0', {
>> > +        # On by default for x64 Linux.
>> > +        ['OS=="linux" and target_arch=="x64"', {
>> >            'linux_use_gold_flags%': 1,
>> >          }, {
>> >            'linux_use_gold_flags%': 0,
>> >
>> >
>> >
>>
>
>
>
https://codereview.chromium.**org/12383041/<https://codereview.chromium.org/1...
>

[Evan Martin, 2013-03-25 23:06:48]

LGTM

noideadog.jpg

[commit-bot: I haz the power, 2013-03-25 23:13:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/12383041/5001

[commit-bot: I haz the power, 2013-03-26 00:43:01]

Retried try job too often on win_rel for step(s) ppapi_unittests,
printing_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-26 08:01:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/12383041/5001

[commit-bot: I haz the power, 2013-03-26 09:49:38]

Change committed as 190623

[Lei Zhang, 2013-03-26 21:16:45]

For the record, this got reverted due to the following error on CrOS. (daisy)
I'll figure out what's going wrong...

make -j16 -r V=1 BUILDTYPE=Release chrome chrome_sandbox
video_decode_accelerator_unittest ppapi_example_video_decode pyautolib
peerconnection_server chromedriver browser_tests ffmpeg_tests
sync_integration_tests nacl_helper_bootstrap nacl_helper libosmesa.so    
 
LD_LIBRARY_PATH=/home/chrome-bot/chrome_root/src/c/Release/lib.host:/home/chrome-bot/chrome_root/src/c/Release/lib.target:$LD_LIBRARY_PATH;
export LD_LIBRARY_PATH; cd chrome; mkdir -p
/home/chrome-bot/chrome_root/src/c/Release/obj/gen/chrome/common; python
tools/build/version.py -f VERSION -f app/theme/chromium/BRANDING -f
../build/util/LASTCHANGE common/chrome_version_info_posix.h.version
"/home/chrome-bot/chrome_root/src/c/Release/obj/gen/chrome/common/chrome_version_info_posix.h"
  x86_64-pc-linux-gnu-g++ -Wl,-z,now -Wl,-z,relro -pthread -Wl,-z,noexecstack
-fPIC -Wl,--threads -Wl,--thread-count=4 -Bc/Release/../../third_party/gold
-Wl,-O1 -Wl,--as-needed -Wl,--gc-sections  -o c/Release/protoc -Wl,--start-group
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/code_generator.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/command_line_interface.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/plugin.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/plugin.pb.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/subprocess.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/zip_writer.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_enum.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_enum_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_extension.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_file.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_generator.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_helpers.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_message.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_message_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_primitive_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_service.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_enum.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_enum_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_extension.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_file.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_generator.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_helpers.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_message.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_message_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_primitive_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_service.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/java/java_string_field.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/python/python_generator.o
c/Release/obj.host/protoc/third_party/protobuf/src/google/protobuf/compiler/main.o
c/Release/obj.host/third_party/protobuf/libprotobuf_full_do_not_use.a
-Wl,--end-group  
/usr/x86_64-pc-linux-gnu/binutils-bin/2.22/ld.bfd.real: unrecognized option
'--threads'
/usr/x86_64-pc-linux-gnu/binutils-bin/2.22/ld.bfd.real: use the --help option
for usage information
collect2: error: ld returned 1 exit status
make: *** [c/Release/protoc] Error 1

[Lei Zhang, 2013-03-26 21:32:16]

-Bc/Release/../../third_party/gold lands us in
/var/cache/chromeos-chrome/chrome-src/src/third_party, which doesn't have a gold
directory. We were expecting to be in ~/chrome_root/src/third_party.