build/android/buildbot/bb_device_steps.py - Issue 12382006: Check if mantarays are charging, and alert on all Android device errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 12382006: Check if mantarays are charging, and alert on all Android device errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix style Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/buildbot/bb_device_steps.py

diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py

index 3acc4c3134a8c93cbbd4164704dbceaeb296a44e..dac86cb6acce3c2a8e001b67ff8189e4b3190167 100755

--- a/build/android/buildbot/bb_device_steps.py

+++ b/build/android/buildbot/bb_device_steps.py

@@ -239,7 +239,7 @@ def MainTestWrapper(options):

# Device check and alert emails

buildbot_report.PrintNamedStep('device_status_check')

- RunCmd(['build/android/device_status_check.py'], flunk_on_failure=False)

+ RunCmd(['build/android/device_status_check.py'], flunk_on_failure=True)

Isaac (away) 2013/03/13 02:54:11 just remove this argument, it defaults to True

Siva Chandra 2013/03/13 20:58:15 Done.

if options.install:

test_obj = INSTRUMENTATION_TESTS[options.install]

« no previous file with comments | « no previous file | build/android/device_status_check.py » ('j') | build/android/device_status_check.py » ('J')