Convert skhello tool to SkFlags API.

Convert skhello tool to SkFlags API.

BUG=https://code.google.com/p/skia/issues/detail?id=1094
R=scroggo@google.com

Signed-off-by: Thiago Farina <tfarina@chromium.org>;


Committed: http://code.google.com/p/skia/source/detail?r=7968

[tfarina, 2013-03-04 20:28:28]

Hi Leon, could you review this to me?

Thanks,

[scroggo, 2013-03-04 20:40:31]

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp
File tools/skhello.cpp (left):

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp#oldcode17
tools/skhello.cpp:17: int tool_main(int argc, char** argv);
I think this prevents a warning on certain platforms, so I think it should be
left there.

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp
File tools/skhello.cpp (right):

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp#newcode14
tools/skhello.cpp:14: DEFINE_string(o, "", "The filename to write the image.");
Why not set "skhello.png" as the default value?

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp#newcode15
tools/skhello.cpp:15: DEFINE_string(t, "", "The string to write.");
Why not set "Hello" as the default value?

[tfarina, 2013-03-04 20:46:10]

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp
File tools/skhello.cpp (left):

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp#oldcode17
tools/skhello.cpp:17: int tool_main(int argc, char** argv);
On 2013/03/04 20:40:31, scroggo wrote:
> I think this prevents a warning on certain platforms, so I think it should be
> left there.

Done.

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp
File tools/skhello.cpp (right):

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp#newcode14
tools/skhello.cpp:14: DEFINE_string(o, "", "The filename to write the image.");
On 2013/03/04 20:40:31, scroggo wrote:
> Why not set "skhello.png" as the default value?

Done.

https://codereview.chromium.org/12381087/diff/1/tools/skhello.cpp#newcode15
tools/skhello.cpp:15: DEFINE_string(t, "", "The string to write.");
On 2013/03/04 20:40:31, scroggo wrote:
> Why not set "Hello" as the default value?

Done.

[scroggo, 2013-03-04 20:57:48]

lgtm

[commit-bot: I haz the power, 2013-03-04 20:57:57]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/12381087/5001

[commit-bot: I haz the power, 2013-03-04 20:58:02]

Change committed as 7968