Windows: Disable GPU sandbox if DisplayLink version 7.1 or earlier is installed.

Windows: Disable GPU sandbox if DisplayLink version 7.1 or earlier is installed.

DisplayLink crashes the GPU process while the Direct3D device is being created if the sandbox is enabled.

Before landing this, I will revert r185146 and rebase so that it merges without conflict.

BUG=177611
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186345

[Ken Russell (switch to Gerrit), 2013-03-05 00:55:50]

LGTM if this is the desired direction (as opposed to, for example, blacklisting
GPU acceleration on these configurations). Please make sure the security team
has signed off on this too.

[commit-bot: I haz the power, 2013-03-05 19:54:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/12381085/3001

[commit-bot: I haz the power, 2013-03-05 19:54:57]

Failed to apply patch for content/browser/gpu/gpu_data_manager_impl.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file content/browser/gpu/gpu_data_manager_impl.cc
  Hunk #1 FAILED at 14.
  Hunk #2 succeeded at 32 (offset 3 lines).
  Hunk #3 FAILED at 37.
  Hunk #4 FAILED at 84.
  Hunk #5 succeeded at 492 with fuzz 2 (offset 55 lines).
  3 out of 5 hunks FAILED -- saving rejects to file
content/browser/gpu/gpu_data_manager_impl.cc.rej

Patch:       content/browser/gpu/gpu_data_manager_impl.cc
Index: content/browser/gpu/gpu_data_manager_impl.cc
===================================================================
--- content/browser/gpu/gpu_data_manager_impl.cc	(revision 184931)
+++ content/browser/gpu/gpu_data_manager_impl.cc	(working copy)
@@ -14,7 +14,9 @@
 #include "base/file_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
+#include "base/string16.h"
 #include "base/string_piece.h"
+#include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/sys_info.h"
 #include "base/values.h"
@@ -29,6 +31,7 @@
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "grit/content_resources.h"
+#include "third_party/re2/re2/re2.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_switches.h"
@@ -36,6 +39,7 @@
 #include "webkit/plugins/plugin_switches.h"
 
 #if defined(OS_WIN)
+#include "base/win/registry.h"
 #include "base/win/windows_version.h"
 #endif
 
@@ -83,6 +87,45 @@
   BLOCK_STATUS_MAX
 };
 
+#if defined(OS_WIN)
+// Checks for version 7.1 or earlier of the DisplayLink software. It causes the
+// GPU process to crash on startup. http://crbug.com/177611
+bool IsOldDisplayLinkInstalled() {
+  base::win::RegKey key;
+
+  if (FAILED(key.Open(
+      HKEY_LOCAL_MACHINE, L"SOFTWARE", KEY_READ | KEY_WOW64_64KEY))) {
+    return false;
+  }
+
+  if (FAILED(key.OpenKey(L"DisplayLink", KEY_READ | KEY_WOW64_64KEY)))
+    return false;
+
+  if (FAILED(key.OpenKey(L"Core", KEY_READ | KEY_WOW64_64KEY)))
+    return false;
+
+  string16 version;
+  if (FAILED(key.ReadValue(L"Version", &version)))
+    return false;
+
+  int major;
+  int minor;
+  if (!RE2::PartialMatch(WideToASCII(version),
+                         "^(\\d)+\\.(\\d)+\\.",
+                         &major,
+                         &minor)) {
+    return false;
+  }
+
+  if (major > 7)
+    return false;
+
+  if (major == 7 && minor > 1)
+    return false;
+
+  return true;
+}
+#endif
 }  // namespace anonymous
 
 // static
@@ -436,6 +479,11 @@
     command_line->AppendSwitchPath(switches::kSwiftShaderPath,
                                    swiftshader_path);
 
+#if defined(OS_WIN)
+  if (IsOldDisplayLinkInstalled())
+    command_line->AppendSwitch(switches::kReduceGpuSandbox);
+#endif
+
   {
     base::AutoLock auto_lock(gpu_info_lock_);
     if (gpu_info_.optimus)

[apatrick_chromium, 2013-03-05 22:42:52]

PTAL

[Ken Russell (switch to Gerrit), 2013-03-05 22:52:44]

Still LGTM

[commit-bot: I haz the power, 2013-03-05 22:56:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/12381085/17001

[commit-bot: I haz the power, 2013-03-05 22:56:33]

Presubmit check for 12381085-17001 failed and returned exit status 1.

INFO:root:Found 4 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/public/common/gpu_info.h

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[apatrick_chromium, 2013-03-05 22:59:53]

+joi for content/public

[Jói, 2013-03-05 23:51:17]

LGTM for content/public.

[commit-bot: I haz the power, 2013-03-06 00:03:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/apatrick@chromium.org/12381085/17001

[commit-bot: I haz the power, 2013-03-06 03:53:47]

Change committed as 186345