Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 12381076: Files.app: Disables browser shortcut keys. (Closed)

Created:
7 years, 9 months ago by yoshiki
Modified:
7 years, 9 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, feature-media-reviews_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Disables browser shortcut keys. BUG=none TEST=Press Ctrl+S on dialogs and confirm nothing is happened. R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M chrome/browser/resources/file_manager/js/action_choice.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/js/media/audio_player.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/media/video_player.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/gallery.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/util.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yoshiki
mtomasz: PTAL
7 years, 9 months ago (2013-03-04 08:46:45 UTC) #1
mtomasz
lgtm. By the way, do you know if we need it on apps v2?
7 years, 9 months ago (2013-03-05 02:19:06 UTC) #2
yoshiki
On 2013/03/05 02:19:06, mtomasz wrote: > lgtm. By the way, do you know if we ...
7 years, 9 months ago (2013-03-05 02:26:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12381076/1
7 years, 9 months ago (2013-03-05 02:28:20 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 04:35:41 UTC) #5
Message was sent while issue was closed.
Change committed as 186099

Powered by Google App Engine
This is Rietveld 408576698