Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 12381038: gm self-test: use a pathologically simple test case instead of dashing2 (Closed)

Created:
7 years, 9 months ago by epoger
Modified:
7 years, 9 months ago
Reviewers:
borenet, rmistry
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

gm self-test: use a pathologically simple test case instead of dashing2 BUG=https://code.google.com/p/skia/issues/detail?id=677 Committed: http://code.google.com/p/skia/source/detail?r=7922

Patch Set 1 #

Total comments: 1

Patch Set 2 : tiny_comment_change #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -113 lines) Patch
A gm/selftest.cpp View 1 chunk +48 lines, -0 lines 0 comments Download
M gm/tests/outputs/aaclip-readback/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/aaclip-write/output-expected/json-summary.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt View 2 chunks +8 lines, -8 lines 1 comment Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/json-summary.txt View 2 chunks +8 lines, -8 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/json-summary.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/json-summary.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/json-summary.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/json-summary.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/json-summary.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/run.sh View 1 4 chunks +22 lines, -31 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
epoger
first LG wins https://codereview.chromium.org/12381038/diff/1/gm/tests/outputs/aaclip-readback/output-expected/json-summary.txt File gm/tests/outputs/aaclip-readback/output-expected/json-summary.txt (right): https://codereview.chromium.org/12381038/diff/1/gm/tests/outputs/aaclip-readback/output-expected/json-summary.txt#newcode8 gm/tests/outputs/aaclip-readback/output-expected/json-summary.txt:8: "checksum" : 8375148850964385904 Now that we ...
7 years, 9 months ago (2013-03-01 12:04:40 UTC) #1
epoger
I launched the following trybots: http://70.32.156.53:10117/builders/Skia_Linux_NoGPU_Debug_32_Trybot/builds/83 passed http://70.32.156.53:10117/builders/Skia_Mac_Float_Debug_64_Trybot/builds/18 has not started yet Although those buildbots ...
7 years, 9 months ago (2013-03-01 13:05:31 UTC) #2
epoger
> Although those buildbots don't run the gm... I mean, they don't run the gm ...
7 years, 9 months ago (2013-03-01 13:06:05 UTC) #3
borenet
LGTM https://codereview.chromium.org/12381038/diff/3001/gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt File gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt (right): https://codereview.chromium.org/12381038/diff/3001/gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt#newcode8 gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt:8: "checksum" : 9948284449770991531 I didn't realize that 8888 ...
7 years, 9 months ago (2013-03-01 13:38:28 UTC) #4
borenet
> Question: do we have a plan to allow tries on the housekeeping bot? We ...
7 years, 9 months ago (2013-03-01 13:39:54 UTC) #5
rmistry
On 2013/03/01 13:39:54, borenet wrote: > > Question: do we have a plan to allow ...
7 years, 9 months ago (2013-03-01 13:43:12 UTC) #6
epoger
Thanks, guys! I split off the offshoot discussions as: https://code.google.com/p/skia/issues/detail?id=1139 ('support tries on the housekeeping ...
7 years, 9 months ago (2013-03-01 15:30:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/12381038/3001
7 years, 9 months ago (2013-03-01 15:32:20 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-01 15:32:38 UTC) #9
Message was sent while issue was closed.
Change committed as 7922

Powered by Google App Engine
This is Rietveld 408576698