Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4851)

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc

Issue 12381035: Move Mime type handling to streamsPrivate API, so that it works on Desktop Chrome. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Initialize test variable Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc
diff --git a/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc b/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ba27e0bb2c5abb9366ca27f5a9d7724c6a91d9d7
--- /dev/null
+++ b/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc
@@ -0,0 +1,70 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/strings/string_number_conversions.h"
+#include "chrome/common/extensions/extension_builder.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_handler.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include "chrome/common/extensions/manifest_url_handler.h"
+#include "chrome/common/extensions/mime_types_handler.h"
+#include "chrome/common/extensions/value_builder.h"
+#include "extensions/common/error_utils.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace errors = extension_manifest_errors;
+
+using extensions::DictionaryBuilder;
+using extensions::Extension;
+using extensions::ExtensionBuilder;
+using extensions::ListBuilder;
+
+namespace {
+
+class StreamsPrivateManifestTest : public ExtensionManifestTest {
+ virtual void SetUp() OVERRIDE {
+ ExtensionManifestTest::SetUp();
+ (new MimeTypesHandlerParser)->Register();
+ }
+};
+
+TEST_F(StreamsPrivateManifestTest, ValidMimeTypesHandlerMIMETypes) {
+ scoped_refptr<const Extension> extension =
+ ExtensionBuilder()
+ .SetID(extension_misc::kQuickOfficeExtensionId)
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "MIME type handler test")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Set("mime_types", ListBuilder()
+ .Append("plain/text")))
+ .Build();
+
+ ASSERT_TRUE(extension.get());
+ MimeTypesHandler* handler = MimeTypesHandler::GetHandler(extension);
+ ASSERT_TRUE(handler != NULL);
+
+ EXPECT_FALSE(handler->CanHandleMIMEType("plain/html"));
+ EXPECT_TRUE(handler->CanHandleMIMEType("plain/text"));
+}
+
+TEST_F(StreamsPrivateManifestTest,
+ MimeTypesHandlerMIMETypesNotWhitelisted) {
+ scoped_refptr<const Extension> extension =
+ ExtensionBuilder()
+ .SetManifest(DictionaryBuilder()
+ .Set("name", "MIME types test")
+ .Set("version", "1.0.0")
+ .Set("manifest_version", 2)
+ .Set("mime_types", ListBuilder()
+ .Append("plain/text")))
+ .Build();
+
+ ASSERT_TRUE(extension.get());
+
+ MimeTypesHandler* handler = MimeTypesHandler::GetHandler(extension);
+ ASSERT_TRUE(handler == NULL);
+}
+
+} // namespace

Powered by Google App Engine
This is Rietveld 408576698