Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc

Issue 12381035: Move Mime type handling to streamsPrivate API, so that it works on Desktop Chrome. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Initialize test variable Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc b/chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc
index c39ede6d80fdfd5dfa0cfacbf0be41dbf7a46032..e2d21f27dc60ed50a43c0c46af7b04d095279529 100644
--- a/chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc
@@ -91,7 +91,6 @@ TEST_F(FileBrowserHandlerManifestTest, ValidFileBrowserHandler) {
EXPECT_FALSE(action->HasCreateAccessPermission());
EXPECT_TRUE(action->CanRead());
EXPECT_TRUE(action->CanWrite());
- EXPECT_FALSE(action->CanHandleMIMEType("plain/text"));
}
TEST_F(FileBrowserHandlerManifestTest, ValidFileBrowserHandlerMIMETypes) {
@@ -108,9 +107,7 @@ TEST_F(FileBrowserHandlerManifestTest, ValidFileBrowserHandlerMIMETypes) {
.Set("default_title", "Default title")
.Set("default_icon", "icon.png")
.Set("file_filters", ListBuilder()
- .Append("filesystem:*.txt"))
- .Set("mime_types", ListBuilder()
- .Append("plain/text")))))
+ .Append("filesystem:*.txt")))))
.Build();
ASSERT_TRUE(extension.get());
@@ -120,37 +117,12 @@ TEST_F(FileBrowserHandlerManifestTest, ValidFileBrowserHandlerMIMETypes) {
ASSERT_EQ(handlers->size(), 1U);
const FileBrowserHandler* action = handlers->at(0).get();
- EXPECT_FALSE(action->CanHandleMIMEType("plain/html"));
- EXPECT_TRUE(action->CanHandleMIMEType("plain/text"));
-
const extensions::URLPatternSet& patterns = action->file_url_patterns();
ASSERT_EQ(patterns.patterns().size(), 1U);
EXPECT_TRUE(action->MatchesURL(
GURL("filesystem:chrome-extension://foo/local/test.txt")));
}
-TEST_F(FileBrowserHandlerManifestTest,
- FileBrowserHandlerMIMETypesNotWhitelisted) {
- scoped_ptr<DictionaryValue> manifest_value =
- DictionaryBuilder()
- .Set("name", "MIME types test")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)
- .Set("file_browser_handlers", ListBuilder()
- .Append(DictionaryBuilder()
- .Set("id", "ID")
- .Set("default_title", "Default title")
- .Set("default_icon", "icon.png")
- .Set("file_filters", ListBuilder()
- .Append("filesystem:*.txt"))
- .Set("mime_types", ListBuilder()
- .Append("plain/text"))))
- .Build();
-
- LoadAndExpectError(Manifest(manifest_value.get(), "MIME types test"),
- errors::kNoPermissionForFileBrowserHandlerMIMETypes);
-}
-
TEST_F(FileBrowserHandlerManifestTest, ValidFileBrowserHandlerWithCreate) {
scoped_refptr<const Extension> extension =
ExtensionBuilder()

Powered by Google App Engine
This is Rietveld 408576698