Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1238053002: Move the WebContents to the AsyncTabCreationParams for tabbed mode (Closed)

Created:
5 years, 5 months ago by gone
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the WebContents to the AsyncTabCreationParams for tabbed mode * ChromeTabCreator (in tabbed mode) may now receive AsyncTabCreationParams with a WebContents inside. * Mechanisms for passing WebContents to ChromeTabbedActivity from WebappActivity/DocumentActivity via Intents are removed. Other parameters will eventually follow. * Changes a WebappModeTest slightly to check for exact Tab IDs again. Doesn't need to be inexact, anymore. * Smushes together two methods in TabDelegate for creating new tabs. They're supposed to be doing something similar, anyway. BUG=508333, 508221 Committed: https://crrev.com/c13bdd545cd70260f86341c3d5a17ec756975f11 Cr-Commit-Position: refs/heads/master@{#339167}

Patch Set 1 #

Patch Set 2 : TabDelegate cleaning #

Total comments: 2

Patch Set 3 : Findbugs #

Messages

Total messages: 14 (5 generated)
gone
5 years, 5 months ago (2015-07-15 22:48:29 UTC) #2
gone
Smashed a second CL on top of this one that does more cleaning/consolidation. Not sure ...
5 years, 5 months ago (2015-07-16 00:30:26 UTC) #3
David Trainor- moved to gerrit
lgtm. Although we might want to use a builder for creation of the AsyncTabCreateParams instead. ...
5 years, 5 months ago (2015-07-16 21:32:18 UTC) #4
gone
https://chromiumcodereview.appspot.com/1238053002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java (right): https://chromiumcodereview.appspot.com/1238053002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java#newcode86 chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java:86: AsyncTabCreationParams asyncParams = On 2015/07/16 21:32:18, David Trainor wrote: ...
5 years, 5 months ago (2015-07-16 22:05:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238053002/20001
5 years, 5 months ago (2015-07-16 22:06:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/97947)
5 years, 5 months ago (2015-07-16 22:39:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238053002/40001
5 years, 5 months ago (2015-07-16 22:47:23 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-16 23:33:47 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 23:34:45 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c13bdd545cd70260f86341c3d5a17ec756975f11
Cr-Commit-Position: refs/heads/master@{#339167}

Powered by Google App Engine
This is Rietveld 408576698