Issue 12380026: Limit EatAtLeast recursion by a budget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12380026: Limit EatAtLeast recursion by a budget. (Closed)

Created:
7 years, 9 months ago by Yang

Modified:
7 years, 9 months ago

Reviewers:
erikcorry, Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Limit EatAtLeast recursion by a budget. BUG=178790 Committed: https://code.google.com/p/v8/source/detail?r=13788

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -98 lines)			Patch
M	src/jsregexp.h	View	14 chunks	+10 lines, -35 lines	1 comment	Download
M	src/jsregexp.cc	View	11 chunks	+41 lines, -50 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-178790.js	View	2 chunks	+15 lines, -13 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

erikcorry

LGTM https://codereview.chromium.org/12380026/diff/1/src/jsregexp.h File src/jsregexp.h (right): https://codereview.chromium.org/12380026/diff/1/src/jsregexp.h#newcode617 src/jsregexp.h:617: static const int kFillInBMBudget = 200; This seems ...

7 years, 9 months ago (2013-03-01 09:15:52 UTC) #2

Yang

7 years, 9 months ago (2013-03-01 14:50:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13788 (presubmit successful).

Expand Messages | Collapse Messages