Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 12380012: Install advancecomp to get advdef for build/sanitize-png-files.sh. (Closed)

Created:
7 years, 9 months ago by msw
Modified:
7 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Install advancecomp to get advdef for build/sanitize-png-files.sh. This should avoid the necessity to manually install advancecomp. BUG=NONE TEST=build/sanitize-png-files.sh installs advancecomp as needed for advdef. R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/sanitize-png-files.sh View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Oshima, please take a look; thanks!
7 years, 9 months ago (2013-02-28 10:44:11 UTC) #1
oshima
lgtm
7 years, 9 months ago (2013-02-28 10:57:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12380012/1
7 years, 9 months ago (2013-02-28 11:29:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12380012/1
7 years, 9 months ago (2013-02-28 17:05:59 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 19:01:16 UTC) #5
Message was sent while issue was closed.
Change committed as 185285

Powered by Google App Engine
This is Rietveld 408576698