Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: chrome/browser/signin/token_service.cc

Issue 12380006: Build a new TokenCacheService so I can stop using TokenService for something it wasn't designed for. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Token Cache Service - post LGTM nits and merging with master Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/token_service.cc
diff --git a/chrome/browser/signin/token_service.cc b/chrome/browser/signin/token_service.cc
index 0cd9c117faf282f309123c9665fe39a84aef9823..b7eff9a2ea2c24eca137c17d32c4b96e73c38c4e 100644
--- a/chrome/browser/signin/token_service.cc
+++ b/chrome/browser/signin/token_service.cc
@@ -100,10 +100,6 @@ void TokenService::Initialize(const char* const source,
}
}
-// TODO(petewil) We should refactor the token_service so it does not both
-// store tokens and fetch them. Move the key-value storage out of
-// token_service, and leave the token fetching in token_service.
-
void TokenService::AddAuthTokenManually(const std::string& service,
const std::string& auth_token) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -405,10 +401,6 @@ void TokenService::LoadTokensIntoMemory(
}
LoadSingleTokenIntoMemory(db_tokens, in_memory_tokens,
GaiaConstants::kGaiaOAuth2LoginRefreshToken);
- // TODO(petewil): Remove next line when we refactor key-value
- // storage out of token_service - http://crbug.com/177125.
- LoadSingleTokenIntoMemory(db_tokens, in_memory_tokens,
- GaiaConstants::kObfuscatedGaiaId);
if (credentials_.lsid.empty() && credentials_.sid.empty()) {
// Look for GAIA SID and LSID tokens. If we have both, and the current
« no previous file with comments | « chrome/browser/profiles/profile_dependency_manager.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698