Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 12379078: Update ndk sysroot to API level 14 (Closed)

Created:
7 years, 9 months ago by leozwang1
Modified:
7 years, 9 months ago
Reviewers:
Yaron, digit1
CC:
chromium-reviews
Base URL:
https://src.chromium.org/svn/trunk/src/
Visibility:
Public.

Description

Update ndk sysroot to API level 14. Update ndk toolchain to api level 14 to make application to be able to setup SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION mode which was introduced in api level 14 in opensl. BUG=179926 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186254

Patch Set 1 #

Patch Set 2 : Address David's comments #

Patch Set 3 : update clang file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/common.gypi View 1 2 chunks +5 lines, -2 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
digit1
Thanks. LGTM Please fix the typo in the comment message, and add a small comment ...
7 years, 9 months ago (2013-03-04 18:38:05 UTC) #1
Yaron
It looks like you missed a few places: tools/clang/scripts/update.sh and also build/android.gypi (in v8) but ...
7 years, 9 months ago (2013-03-04 19:20:11 UTC) #2
digit1
To answer a few of Yaron's statements: On Mon, Mar 4, 2013 at 8:20 PM, ...
7 years, 9 months ago (2013-03-04 22:05:35 UTC) #3
Yaron
On 2013/03/04 22:05:35, digit1 wrote: > To answer a few of Yaron's statements: > > ...
7 years, 9 months ago (2013-03-04 23:08:02 UTC) #4
leozwang1
PTAL, will commit tomorrow if there is no more problem.
7 years, 9 months ago (2013-03-05 05:26:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leozwang@chromium.org/12379078/4011
7 years, 9 months ago (2013-03-05 15:07:16 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=105257
7 years, 9 months ago (2013-03-05 16:37:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leozwang@chromium.org/12379078/4011
7 years, 9 months ago (2013-03-05 19:51:02 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 20:54:34 UTC) #9
Message was sent while issue was closed.
Change committed as 186254

Powered by Google App Engine
This is Rietveld 408576698