Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 12379066: Temporary fix for build break when removing Java files or resources. (Closed)

Created:
7 years, 9 months ago by newt (away)
Modified:
7 years, 9 months ago
Reviewers:
cjhopman, Nico
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, Yaron, bulach
Visibility:
Public.

Description

Temporary fix for build break when removing Java files or resources. This appends the list of inputs to the ant and process_resources.py commands. Thus when the list of inputs changes, the command line changes, and ninja will re-run the command. This will be removed once ninja is updated to automatically rebuild when the input list changes. BUG=177449, 177552 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186299

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M build/android/process_resources.py View 1 chunk +3 lines, -0 lines 0 comments Download
M build/java.gypi View 2 chunks +10 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
newt (away)
This ain't especially pretty, but it's simple and it works. I've verified that removing a ...
7 years, 9 months ago (2013-03-02 01:00:26 UTC) #1
Nico
lgtm This works for me if Chris can live with it. Thanks!
7 years, 9 months ago (2013-03-04 08:25:09 UTC) #2
cjhopman
lgtm
7 years, 9 months ago (2013-03-05 18:46:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12379066/1
7 years, 9 months ago (2013-03-05 18:48:26 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-05 18:59:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12379066/5005
7 years, 9 months ago (2013-03-05 19:58:30 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-05 20:05:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/12379066/5005
7 years, 9 months ago (2013-03-05 22:23:53 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-06 00:36:49 UTC) #9
Message was sent while issue was closed.
Change committed as 186299

Powered by Google App Engine
This is Rietveld 408576698