Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 12379014: Hide add new profile menu entry for managed users. (Closed)

Created:
7 years, 9 months ago by Adrian Kuegel
Modified:
7 years, 9 months ago
CC:
chromium-reviews, tfarina, sail+watch_chromium.org
Visibility:
Public.

Description

Hide add new profile menu entry for managed users. Currently only implemented for gtk and aura. The screenshots can be found here: https://drive.google.com/a/google.com/folderview?id=0BzMCIwDgeNezVmNHSG5pUXoxVGs&usp=sharing BUG=171370 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185877

Patch Set 1 #

Patch Set 2 : Extract avatar_menu_bubble_view.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M chrome/browser/profiles/avatar_menu_model.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_model.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc View 1 chunk +14 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Adrian Kuegel
Elliot, can you please review the files in chrome/browser/profiles and in chrome/browser/ui/gtk ? Peter, can ...
7 years, 9 months ago (2013-02-28 15:25:11 UTC) #1
Elliot Glaysher
profiles and gtk lgtm On what timeframe will you be removing the ifdefs?
7 years, 9 months ago (2013-03-01 21:05:48 UTC) #2
Peter Kasting
views LGTM, but you should probably add commentary in the header that |separator_| and |add_profile_link_| ...
7 years, 9 months ago (2013-03-01 21:58:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/12379014/10001
7 years, 9 months ago (2013-03-04 09:14:14 UTC) #4
Adrian Kuegel
I am not sure, when they will be removed. The ENABLE_MANAGED_USERS flag is set automatically ...
7 years, 9 months ago (2013-03-04 09:16:10 UTC) #5
Adrian Kuegel
I just realized that there went something wrong when I uploaded the changelist, so the ...
7 years, 9 months ago (2013-03-04 09:18:10 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-04 12:27:43 UTC) #7
Message was sent while issue was closed.
Change committed as 185877

Powered by Google App Engine
This is Rietveld 408576698