Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 12378094: Implement WebKit::Platform::isThreadedCompositingEnabled() (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Implement WebKit::Platform::isThreadedCompositingEnabled() This provides implementations of WK::Platform::isThreadedCompositingEnabled() for content/renderer/renderer_webkitplatformsupport_impl (aka the one we really use) and for the unit / layout test support logic in webkit/. The real implementation depends on content::RenderThreadImpl::compositor_thread(), the test implementations have to be set explicitly by the test harness. Neither depend on WebCompositorSupport, although that's still implemented so everything still passes before the WebKit side at https://bugs.webkit.org/show_bug.cgi?id=111386 lands and rolls in. R=enne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 3 chunks +6 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 2 chunks +6 lines, -1 line 0 comments Download
M webkit/support/webkit_support.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
This is the first step towards relanding https://codereview.chromium.org/12386078. Plan is land this, then roll into ...
7 years, 9 months ago (2013-03-05 01:49:22 UTC) #1
enne (OOO)
lgtm
7 years, 9 months ago (2013-03-05 02:04:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12378094/1
7 years, 9 months ago (2013-03-05 02:08:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=105117
7 years, 9 months ago (2013-03-05 04:22:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/12378094/1
7 years, 9 months ago (2013-03-05 05:01:51 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 06:03:50 UTC) #6
Message was sent while issue was closed.
Change committed as 186111

Powered by Google App Engine
This is Rietveld 408576698