Issue 12378079: Modify managed_mode_private extensions api to use JSON Schema Compiler

Issue 12378079: Modify managed_mode_private extensions api to use JSON Schema Compiler (Closed)

Created:
7 years, 9 months ago by Aaron Jacobs

Modified:
7 years, 9 months ago

Reviewers:
Devlin, cduvall, Pam (message me for reviews), Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, pam+watch_chromium.org, chromium-apps-reviews_chromium.org, Bernhard Bauer

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Modify managed_mode_private extensions api to use JSON Schema Compiler BUG=121174 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190029

Patch Set 2 : cduvall's requests #

Patch Set 3 : Removed AUTHORS file change #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	chrome/browser/extensions/api/managed_mode_private/managed_mode_private_api.cc	View	1	4 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

Thanks for the contribution! We really appreciate cleanup work like this. It's worth noting that ...

7 years, 9 months ago (2013-03-04 17:59:34 UTC) #2

cduvall

https://codereview.chromium.org/12378079/diff/1/chrome/browser/extensions/api/managed_mode_private/managed_mode_private_api.cc File chrome/browser/extensions/api/managed_mode_private/managed_mode_private_api.cc (right): https://codereview.chromium.org/12378079/diff/1/chrome/browser/extensions/api/managed_mode_private/managed_mode_private_api.cc#newcode30 chrome/browser/extensions/api/managed_mode_private/managed_mode_private_api.cc:30: namespace GetPolicy = extensions::api::managed_mode_private::GetPolicy; Move into namespace extensions block.

7 years, 9 months ago (2013-03-05 21:59:38 UTC) #3

Aaron Jacobs

7 years, 9 months ago (2013-03-05 22:56:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/12378079/9001

7 years, 9 months ago (2013-03-22 20:33:55 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/12378079/9001

7 years, 9 months ago (2013-03-23 14:43:27 UTC) #9

Message was sent while issue was closed.

Change committed as 190029

Expand Messages | Collapse Messages